Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: resolve bugsnag issue in braze #3474

Merged
merged 6 commits into from
Jun 26, 2024
Merged

chore: resolve bugsnag issue in braze #3474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
64637ce
chore: resolve bugsnag issue in braze
sandeepdsvs Jun 18, 2024
f0c5b67
chore: resolve bugsnag issue in braze
sandeepdsvs Jun 19, 2024
b83c77d
chore: added tests
sandeepdsvs Jun 24, 2024
60f4a7b
chore: added tests
sandeepdsvs Jun 24, 2024
057d9a7
Merge branch 'develop' into chore.bugsbag-braze
sandeepdsvs Jun 24, 2024
512243a
fix: instead of throwing error now ignoring the undefined value in th…
sandeepdsvs Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/v0/destinations/braze/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,8 @@ function getPurchaseObjs(message, config) {
'Invalid Order Completed event: Properties object is missing in the message',
);
}
const { products, currency: currencyCode } = properties;
const { currency: currencyCode } = properties;
let { products } = properties;
if (!products) {
throw new InstrumentationError(
'Invalid Order Completed event: Products array is missing in the message',
Expand All @@ -581,6 +582,7 @@ function getPurchaseObjs(message, config) {
throw new InstrumentationError('Invalid Order Completed event: Products is not an array');
}

products = products.filter((product) => isDefinedAndNotNull(product));
if (products.length === 0) {
throw new InstrumentationError('Invalid Order Completed event: Products array is empty');
}
Expand Down
214 changes: 214 additions & 0 deletions test/integrations/destinations/braze/processor/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4111,4 +4111,218 @@ export const data = [
},
},
},
{
name: 'braze',
description: 'Test 30',
feature: 'processor',
module: 'destination',
version: 'v0',
input: {
request: {
body: [
{
message: {
type: 'track',
event: 'Order Completed',
sentAt: '2020-09-14T12:09:37.491Z',
userId: 'Randomuser2222',
channel: 'web',
context: {
os: {
name: '',
version: '',
},
app: {
name: 'RudderLabs JavaScript SDK',
build: '1.0.0',
version: '1.1.3',
namespace: 'com.rudderlabs.javascript',
},
page: {
url: 'file:///Users/manashi/Desktop/rudder-all-sdk-application-testing/Fullstory%20test%20By%20JS%20SDK/braze.html',
path: '/Users/manashi/Desktop/rudder-all-sdk-application-testing/Fullstory%20test%20By%20JS%20SDK/braze.html',
title: 'Fullstory Test',
search: '',
referrer: '',
},
locale: 'en-GB',
screen: {
density: 2,
},
traits: {
email: '[email protected]',
},
library: {
name: 'RudderLabs JavaScript SDK',
version: '1.1.3',
},
userAgent:
'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36',
},
messageId: '24ecc509-ce3e-473c-8483-ba1ea2c195cb',
properties: {
products: [
null,
{
sku: '45790-32',
url: 'https://www.example.com/product/path',
key1: {
key11: 'value1',
key22: 'value2',
},
name: 'Monopoly: 3rd Edition',
price: 19,
category: 'Games',
quantity: 1,
image_url: 'https:///www.example.com/product/path.jpg',
currency78: 'USD',
product_id: '507f1f77bcf86cd799439011',
},
],
},
anonymousId: 'c6ff1462-b692-43d6-8f6a-659efedc99ea',
integrations: {
All: true,
},
originalTimestamp: '2020-09-14T12:09:37.491Z',
},
destination: {
Config: {
restApiKey: 'dummyApiKey',
prefixProperties: true,
useNativeSDK: false,
},
DestinationDefinition: {
DisplayName: 'Braze',
ID: '1WhbSZ6uA3H5ChVifHpfL2H6sie',
Name: 'BRAZE',
},
Enabled: true,
ID: '1WhcOCGgj9asZu850HvugU2C3Aq',
Name: 'Braze',
Transformations: [],
},
},
],
},
},
output: {
response: {
status: 200,
body: [
{
statusCode: 400,
error:
'Invalid Order Completed event: Message properties and product at index: 0 is missing currency',
statTags: {
errorCategory: 'dataValidation',
errorType: 'instrumentation',
destType: 'BRAZE',
module: 'destination',
implementation: 'native',
feature: 'processor',
},
},
],
},
},
},
{
name: 'braze',
description: 'Test 31',
feature: 'processor',
module: 'destination',
version: 'v0',
input: {
request: {
body: [
{
message: {
type: 'track',
event: 'Order Completed',
sentAt: '2020-09-14T12:09:37.491Z',
userId: 'Randomuser2222',
channel: 'web',
context: {
os: {
name: '',
version: '',
},
app: {
name: 'RudderLabs JavaScript SDK',
build: '1.0.0',
version: '1.1.3',
namespace: 'com.rudderlabs.javascript',
},
page: {
url: 'file:///Users/manashi/Desktop/rudder-all-sdk-application-testing/Fullstory%20test%20By%20JS%20SDK/braze.html',
path: '/Users/manashi/Desktop/rudder-all-sdk-application-testing/Fullstory%20test%20By%20JS%20SDK/braze.html',
title: 'Fullstory Test',
search: '',
referrer: '',
},
locale: 'en-GB',
screen: {
density: 2,
},
traits: {
email: '[email protected]',
},
library: {
name: 'RudderLabs JavaScript SDK',
version: '1.1.3',
},
userAgent:
'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36',
},
messageId: '24ecc509-ce3e-473c-8483-ba1ea2c195cb',
properties: {
products: [undefined],
},
anonymousId: 'c6ff1462-b692-43d6-8f6a-659efedc99ea',
integrations: {
All: true,
},
originalTimestamp: '2020-09-14T12:09:37.491Z',
},
destination: {
Config: {
restApiKey: 'dummyApiKey',
prefixProperties: true,
useNativeSDK: false,
},
DestinationDefinition: {
DisplayName: 'Braze',
ID: '1WhbSZ6uA3H5ChVifHpfL2H6sie',
Name: 'BRAZE',
},
Enabled: true,
ID: '1WhcOCGgj9asZu850HvugU2C3Aq',
Name: 'Braze',
Transformations: [],
},
},
],
},
},
output: {
response: {
status: 200,
body: [
{
statusCode: 400,
error: 'Invalid Order Completed event: Products array is empty',
statTags: {
errorCategory: 'dataValidation',
errorType: 'instrumentation',
destType: 'BRAZE',
module: 'destination',
implementation: 'native',
feature: 'processor',
},
},
],
},
},
},
];
Loading