Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize UnDerefer #99667

Merged
merged 5 commits into from
Jul 29, 2022
Merged

Optimize UnDerefer #99667

merged 5 commits into from
Jul 29, 2022

Conversation

ouz-a
Copy link
Contributor

@ouz-a ouz-a commented Jul 24, 2022

Addresses the performance issues faced here.

r? @oli-obk

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 24, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2022

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Jul 25, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 25, 2022
@bors
Copy link
Contributor

bors commented Jul 25, 2022

⌛ Trying commit 4e726e0 with merge 8031317c89b74b4d7df7bd6f3f000fafec11203d...

@bors
Copy link
Contributor

bors commented Jul 25, 2022

☀️ Try build successful - checks-actions
Build commit: 8031317c89b74b4d7df7bd6f3f000fafec11203d (8031317c89b74b4d7df7bd6f3f000fafec11203d)

@rust-timer
Copy link
Collaborator

Queued 8031317c89b74b4d7df7bd6f3f000fafec11203d with parent 7f93d4a, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8031317c89b74b4d7df7bd6f3f000fafec11203d): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.2% -2.2% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -2.2% -2.2% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 25, 2022
@ouz-a ouz-a mentioned this pull request Jul 25, 2022
Closed
oli-obk
oli-obk requested changes Jul 28, 2022
View reviewed changes
compiler/rustc_mir_dataflow/src/rustc_peek.rs Outdated Show resolved Hide resolved
compiler/rustc_mir_dataflow/src/move_paths/builder.rs Outdated Show resolved Hide resolved
compiler/rustc_mir_dataflow/src/move_paths/builder.rs Outdated Show resolved Hide resolved
@oli-obk
Copy link
Contributor

oli-obk commented Jul 28, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jul 28, 2022

📌 Commit bd24b40 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2022
@bors
Copy link
Contributor

bors commented Jul 29, 2022

⌛ Testing commit bd24b40 with merge 7dfdd64...

@bors
Copy link
Contributor

bors commented Jul 29, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 7dfdd64 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 29, 2022
@bors bors merged commit 7dfdd64 into rust-lang:master Jul 29, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 29, 2022
@bors bors mentioned this pull request Jul 29, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7dfdd64): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -0.3% -0.3% 1
Improvements 🎉
(secondary)		 -0.3% -0.3% 1
All 😿🎉 (primary) -0.3% -0.3% 1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.3% -2.3% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -2.3% -2.3% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk requested changes

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ouz-a @rustbot @oli-obk @rust-timer @bors @rust-highfive