Move PlatformSpecificWindowBuilderAttributes into WindowAttributes
#3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
requested review from
jackpot51,
msiglreith,
madsmtm and
kchibisov
as code owners
daxpedda
changed the title
PlatformSpecificWindowBuilderAttributesPlatformSpecificWindowBuilderAttributes into WindowAttributes
daxpedda
force-pushed
the
platform-specific-window-builder-attributes
branch
2 times, most recently
from
4e80ab2 to
d9f66dc
Compare
daxpedda
force-pushed
the
platform-specific-window-builder-attributes
branch
from
d9f66dc to
b4023a2
Compare
madsmtm
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
I've been hesitant to review this because I dislike WindowAttributes on a philosophical level, but I think this is the right approach forwards.
Would also make it easier to move towards event_loop.create_window(attributes) as proposed in #3367, which would in turn make #3299 easier to move forwards on.
In general the |
kchibisov
reviewed
Jan 15, 2024
5 tasks
daxpedda
force-pushed
the
platform-specific-window-builder-attributes
branch
2 times, most recently
from
fa3417b to
eb0117c
Compare
daxpedda
force-pushed
the
platform-specific-window-builder-attributes
branch
from
eb0117c to
ef164ea
Compare
jpedrick
pushed a commit
to jpedrick/winit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3313.
Any unsoundness this expands on is addressed by #3303.
This doesn't actually implement any getters, these can be implemented in follow-ups as needed.