Variable length string array support #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bad hack and should only serve as a proof of (bad) concept
This was referenced Mar 11, 2023
|
How does this relate to https://zarr.dev/zeps/draft/ZEP0003.html ? |
|
AFAIK, chunking is only done on the de-serialized arrays. So, as soon as N5 supports this in general, this should also work for String arrays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a working but far-from-optimal solution to read and write variable length (vlen) string arrays, which are part of hdf5 and zarr but currently not supported by the N5 API.
Basically, I've created a
DataBlock<String[]>that handles (de-)serialization of a C-style null-terminated string array. This necessitates that the block implements constructors forString[]andbyte[], which may be a sign that IO operations and serialization logic is not sufficiently separated for non-primitive types.I would propose this PR as a starting point towards separating IO operations (raw bytes) from custom serialization logic such that other data types may easily be added in the future; see also Issue #93 -- thanks @bogovicj!
@axtimwalde, what's you opinion on this topic?