-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i1020] - correct ga4 typo that prevents download tracking #6897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Google Analytics we were missing the tracking for download events. This is because there was a typo in content_id. Issue: - scientist-softserv/palni-palci#1020
1 task
Fix another typo
orangewolf
approved these changes
Sep 3, 2024
Test Results 17 files ±0 17 suites ±0 2h 20m 2s ⏱️ + 4m 2s Results for commit ce01a3a. ± Comparison against base commit b02cd98. This pull request removes 274 and adds 274 tests. Note that renamed tests count towards both.
|
6 tasks
ShanaLMoore
added a commit
to samvera/hyku
that referenced
this pull request
Sep 3, 2024
pulls in ga4 typo fix - samvera/hyrax#6897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Google Analytics we were missing the tracking for download events. This is because there was a typo in content_id.
Issue:
BEFORE
download events weren't being tracked
AFTER
Rob was able to manually trigger this event