-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cram chunking for PacBio and Nanopore #130
Conversation
1.3.0 Release
patch 1.3.1
BBtools citation
…PacBio FASTQ input
Co-authored-by: Matthieu Muffato <[email protected]>
Co-authored-by: Matthieu Muffato <[email protected]>
prettier linting
prettier linting
Patch 1.3.1
Hi @tkchafin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good and I'm able to run the full pipeline with chunking across all read types now. We can track merging the PacBio filtering into the map-reduce as a separate issue. One thing it it would be nice to track down the sources of all the WARN: The operator
first is useless when applied to a value channel which returns a single value by definition
warnings
Hi @tkchafin, I’ve made the changes based on your feedback. Thank you! |
MINIMAP2_MAPREDUCE
intoalign_ont
andalign_pacbio
seqtk/subseq
bybbmap/filterbyread
GENERATE_CRAM_CSV
andSAMTOOLS_ADDREPLACERG
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).