Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cram chunking for PacBio and Nanopore #130

Merged
merged 39 commits into from
Oct 24, 2024

Conversation

reichan1998
Copy link
Contributor

  • Add MINIMAP2_MAPREDUCE into align_ont and align_pacbio
  • Replace seqtk/subseq by bbmap/filterbyread
  • Adjust resource for GENERATE_CRAM_CSV and SAMTOOLS_ADDREPLACERG

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@reichan1998
Copy link
Contributor Author

reichan1998 commented Sep 26, 2024

Hi @tkchafin,
I've added some updates from patch 1.3.1 (replicated your code). Please let me know if I did anything incorrectly, and I'll make the necessary corrections.

Copy link
Contributor

@tkchafin tkchafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good and I'm able to run the full pipeline with chunking across all read types now. We can track merging the PacBio filtering into the map-reduce as a separate issue. One thing it it would be nice to track down the sources of all the WARN: The operator first is useless when applied to a value channel which returns a single value by definition warnings

@reichan1998
Copy link
Contributor Author

Hi @tkchafin, I’ve made the changes based on your feedback. Thank you!

@tkchafin tkchafin merged commit 90910b7 into sanger-tol:dev Oct 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants