Add pip metadata for scallopy #35
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liby99
reviewed
Dec 4, 2024
| @@ -2,6 +2,7 @@ | |||
| #![feature(extract_if)] | |||
| #![feature(hash_extract_if)] | |||
| #![feature(proc_macro_span)] | |||
| #![feature(iter_repeat_n)] | |||
There was a problem hiding this comment.
I wonder why is this needed because the latest Rust distribution seems to have stabilized the feature.
There was a problem hiding this comment.
Hi, without adding it, the installing scallopy using pip will fail. Sorry I'm not very familiar with rust. I think you can also try running pip install ./etc/scallopy and see what happened if not adding this feature.
There was a problem hiding this comment.
Thanks. The checks have passed anyway so I'll move ahead and merge the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current installation of
scallopyrequires cloning the repository then usemakeormaturinto install the library.In this PR, I added the
pyproject.tomltoscallopysubfolder, and added a declaration of used features incore/src/lib.rs, allowing it can be directly installed bypip.With these changes, users can install
scallopybyOr even NO NEED TO CLONE.
I believe this contribution can improve the package distribution process. As it is compiling from source, there should be no Python version and CPU architecture constrain.