Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip metadata for scallopy #35

Merged
merged 1 commit into from
Dec 4, 2024
+5 −0
Merged

Add pip metadata for scallopy #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#![feature(extract_if)]
#![feature(hash_extract_if)]
#![feature(proc_macro_span)]
#![feature(iter_repeat_n)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why is this needed because the latest Rust distribution seems to have stabilized the feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, without adding it, the installing scallopy using pip will fail. Sorry I'm not very familiar with rust. I think you can also try running pip install ./etc/scallopy and see what happened if not adding this feature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The checks have passed anyway so I'll move ahead and merge the PR.


pub mod common;
pub mod compiler;
Expand Down
4 changes: 4 additions & 0 deletions etc/scallopy/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[build-system]
requires = ["maturin>=1.5,<2.0"]
build-backend = "maturin"

Loading