-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: distribution messages #34
Conversation
TallyReward, | ||
ExecutorReward, | ||
RelayerReward, | ||
TimedOut, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't decided what happens with the funds when a timeout happens, nice one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this repo, but we discussed that we could have a tally parameter for a fixed gas amount for timeout DRs. That would mean that timeout DRs will have a small cost and the rest can be refunded to the requestor.
4554490
to
ad0a6d6
Compare
@@ -1,6 +1,6 @@ | |||
[package] | |||
name = "seda-common" | |||
version = "0.2.0" | |||
version = "0.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to start matching versions to the devnet version?
If so, this could be something like 0.5.0-dev1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I don't think matching versions makes sense. Since they could be in very different development cycles, but that's my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna merge for now, and if we decide to do this I can do it in a future PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Motivation
We want messages so you can distribute the data request escrow.
Explanation of Changes
Testing
Test changes and all tests pass.
Related PRs and Issues
N/A