Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: distribution messages #34

Merged
merged 2 commits into from
Dec 20, 2024
Merged

feat: distribution messages #34

merged 2 commits into from
Dec 20, 2024

Conversation

gluax
Copy link
Contributor

@gluax gluax commented Dec 19, 2024

Motivation

We want messages so you can distribute the data request escrow.

Explanation of Changes

  • Remove the remove singular data request, because I don't think we used and was more annoying to keep.
  • Add the new types and test the json form of them.

Testing

Test changes and all tests pass.

Related PRs and Issues

N/A

crates/common/src/msgs/data_requests/sudo/mod.rs Outdated Show resolved Hide resolved
TallyReward,
ExecutorReward,
RelayerReward,
TimedOut,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't decided what happens with the funds when a timeout happens, nice one!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this repo, but we discussed that we could have a tally parameter for a fixed gas amount for timeout DRs. That would mean that timeout DRs will have a small cost and the rest can be refunded to the requestor.

@gluax gluax force-pushed the feat/funds-distribution branch from 4554490 to ad0a6d6 Compare December 19, 2024 20:53
@gluax gluax requested a review from Thomasvdam December 19, 2024 20:53
@@ -1,6 +1,6 @@
[package]
name = "seda-common"
version = "0.2.0"
version = "0.4.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to start matching versions to the devnet version?
If so, this could be something like 0.5.0-dev1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I don't think matching versions makes sense. Since they could be in very different development cycles, but that's my opinion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna merge for now, and if we decide to do this I can do it in a future PR

Copy link
Member

@mariocao mariocao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gluax gluax merged commit ad0a6d6 into main Dec 20, 2024
2 checks passed
@gluax gluax deleted the feat/funds-distribution branch December 20, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants