generated from seqan/library-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Make the HIBF constructible from a layout file. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
smehringer
force-pushed
the
from_layout
branch
from
August 22, 2023 12:03
1ee5448
to
2b086d6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 91.10% 91.87% +0.76%
==========================================
Files 37 40 +3
Lines 1226 1341 +115
==========================================
+ Hits 1117 1232 +115
Misses 109 109
☔ View full report in Codecov by Sentry. |
smehringer
force-pushed
the
from_layout
branch
from
August 23, 2023 07:17
b4d9274
to
96456d7
Compare
seqan-actions
added
lint
[INTERNAL] used for linting
and removed
lint
[INTERNAL] used for linting
labels
Aug 23, 2023
smehringer
force-pushed
the
from_layout
branch
from
August 23, 2023 11:58
873a978
to
4b852d5
Compare
seqan-actions
added
lint
[INTERNAL] used for linting
and removed
lint
[INTERNAL] used for linting
labels
Aug 23, 2023
smehringer
force-pushed
the
from_layout
branch
from
August 23, 2023 11:59
4b852d5
to
a2fa58b
Compare
seqan-actions
added
lint
[INTERNAL] used for linting
and removed
lint
[INTERNAL] used for linting
labels
Aug 23, 2023
eseiler
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed s.t. raptor can still have the submodule
raptor layout
.We want to keep layouting and building separate s.t. it can be easily benchmarked independently. It counts as a preprocessing step.
Things discussed:
[RESOLUTION: for now, only stream. Later on maybe both.]
input_fn
. Thus, the user has to make sure to provide the correct hash_function. Chopper could write an additional header that provides all the files in the correct order.[RESOLUTION: chopper will add more meta information at the start of the layout file that raptor can parse but the hibf lib will ignore]