-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rspec-specific GitHub workflow #215
Conversation
WalkthroughThe changes enhance the configurability of RSpec testing workflows in GitHub Actions. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/rspec-shared.yml (2 hunks)
- .github/workflows/rspec-specific.yml (1 hunks)
Additional comments not posted (5)
.github/workflows/rspec-specific.yml (3)
1-4
: LGTM! Workflow metadata is correctly defined.The workflow name and trigger are appropriately set up.
5-8
: LGTM! Input definitions are correctly set up.The
spec_paths
input is well-defined with a description and required flag.
10-18
: LGTM! Job definitions are correctly set up.The job uses the shared workflow and passes the necessary inputs and secrets correctly.
.github/workflows/rspec-shared.yml (2)
13-16
: LGTM! Input parameter modifications enhance configurability.The
test-tag
input is now optional, and the newspec_paths
input allows specifying test paths.
47-47
: LGTM! Test command modification is correctly implemented.The command now conditionally includes the
test-tag
and appendsspec_paths
.
b819060
to
8ccece5
Compare
8ccece5
to
3df9da9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments.
By the way, what do you mean by "Setup Control Plane tools step is intentionally skipped"?
I removed "Setup Control Plane tools step is intentionally skipped" from |
1. Replace `-` with `_` for inputs 2. Rename rspec-specific-tests to rspec-specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- .github/workflows/command_docs.yml (1 hunks)
- .github/workflows/rspec-shared.yml (3 hunks)
- .github/workflows/rspec-specific.yml (1 hunks)
- .github/workflows/rspec.yml (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/command_docs.yml
- .github/workflows/rspec.yml
Files skipped from review as they are similar to previous changes (2)
- .github/workflows/rspec-shared.yml
- .github/workflows/rspec-specific.yml
d9b0319
to
6ad601f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/rspec-shared.yml (3 hunks)
- .github/workflows/rspec-specific.yml (1 hunks)
- .github/workflows/rspec.yml (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/rspec.yml
Files skipped from review as they are similar to previous changes (2)
- .github/workflows/rspec-shared.yml
- .github/workflows/rspec-specific.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
What does this PR do and why?
This PR adds new
rspec-spicific
GitHub workflow so that job can be triggered manually to run specific testsDoes it work?
Example of manually triggered job with passing
spec/command/config_spec.rb
asspec_paths
argument - https://github.com/zzaakiirr/control-plane-flow/actions/runs/10020011552/job/27697199967Note, that "Setup Control Plane tools" step is intentionally skipped and tests fail because of that
Summary by CodeRabbit
Summary by CodeRabbit
New Features
test_tag
optional and addingspec_paths
for more targeted test executions.Improvements