Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: solana chain adapter #7925

Merged
merged 7 commits into from
Oct 15, 2024
Merged

feat: solana chain adapter #7925

merged 7 commits into from
Oct 15, 2024

Conversation

kaladinlight
Copy link
Contributor

Description

Solana chain adapter support

Issue (if applicable)

closes #7739

Risk

High Risk PRs Require 2 approvals

Low - behind feature flag

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Code review, nothing much to test until the actual web support pr

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

N/A

Screenshots (if applicable)

@kaladinlight kaladinlight requested a review from a team as a code owner October 11, 2024 18:59
0xApotheosis
0xApotheosis reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looking good, one open question.

packages/chain-adapters/src/solana/SolanaChainAdapter.ts Outdated Show resolved Hide resolved
@0xApotheosis 0xApotheosis self-assigned this Oct 14, 2024
NeOMakinG
NeOMakinG reviewed Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments but looks sane overall!

packages/chain-adapters/src/solana/SolanaChainAdapter.ts Show resolved Hide resolved
packages/chain-adapters/src/solana/SolanaChainAdapter.ts Show resolved Hide resolved
@NeOMakinG NeOMakinG mentioned this pull request Oct 14, 2024
Merged
1 task
Base automatically changed from solana-parser to develop October 15, 2024 01:59
0xApotheosis
0xApotheosis approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asset namespace issue resolved, good to go 👌

@0xApotheosis 0xApotheosis enabled auto-merge (squash) October 15, 2024 02:02
@0xApotheosis 0xApotheosis merged commit b141871 into develop Oct 15, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the solana-chain-adapter branch October 15, 2024 02:12
@gomesalexandre gomesalexandre mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomesalexandre gomesalexandre gomesalexandre left review comments

@NeOMakinG NeOMakinG NeOMakinG left review comments

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

Assignees

@0xApotheosis 0xApotheosis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaladinlight @NeOMakinG @gomesalexandre @0xApotheosis