Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make solana caip compliant again #7930

Merged
merged 3 commits into from
Oct 14, 2024
Merged

fix: make solana caip compliant again #7930

merged 3 commits into from
Oct 14, 2024

Conversation

NeOMakinG
Copy link
Collaborator

Description

I initially used spl as assetNamespace which is for reference wrong (#7925 (comment)) as CAIP19 defined the assetNamespace as token

In this PR I replaced every spl occurrences by token

Issue (if applicable)

n/a

Risk

No risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Turn the solana flag on and verify that Solana assets are working fine (SOl, MEW, JUP...)

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

image
image
image
image

@NeOMakinG NeOMakinG requested a review from a team as a code owner October 14, 2024 12:59
@NeOMakinG NeOMakinG mentioned this pull request Oct 14, 2024
Merged
1 task
gomesalexandre
gomesalexandre approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Couldn't find any stale spl references in project

@NeOMakinG NeOMakinG enabled auto-merge (squash) October 14, 2024 15:19
@NeOMakinG NeOMakinG merged commit 5429570 into develop Oct 14, 2024
3 checks passed
@NeOMakinG NeOMakinG deleted the solana-caip branch October 14, 2024 15:24
@gomesalexandre gomesalexandre mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladinlight kaladinlight kaladinlight approved these changes

@gomesalexandre gomesalexandre gomesalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeOMakinG @gomesalexandre @kaladinlight