chore: consolidate cowswap utils #8331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/MultiHopTrade/components/LimitOrder/components/LimitOrderList.tsx
Show resolved
Hide resolved
gomesalexandre
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Hell yeah to keeping the house tidy 🧹
Spot check looking gucci.
Spot: https://jam.dev/c/ce6219e0-7d96-405b-9f82-cb71580272e2
Limit: https://jam.dev/c/38dfc269-f15b-4131-846e-a69a06047cab
@woodenfurniture noting execution is sad on the Jam above for limit, though confirmed this is isolated to limit and spot isn't affected: https://jam.dev/c/cda1470a-ef58-4250-81cb-310a90301efe
Also confirmed this isn't a regression introduced by this PR by testing on upstream develop: https://jam.dev/c/4cf981c4-8d84-4e03-83c8-761b10aec9c0
Authored #8333 for it :fridaydog:
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves shared utils and constants for cowswap into
@shapeshiftoss/swapperundercowswap-utils.Issue (if applicable)
closes #8214
Risk
Very low risk of broken cowswap trades - utils were only moved without changes to logic.
Cowswap trades.
Testing
Sanity check cowswap trades are working correctly.
Engineering
Operations
Screenshots (if applicable)
Cowswap trade after chagnes:
https://jam.dev/c/916e56d9-37b0-4f1c-9e26-e5eb40cc1319