Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: limit order selectBuyAmountCryptoBaseUnit return int #8333

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix: limit order selectBuyAmountCryptoBaseUnit return int #8333

merged 2 commits into from
Dec 11, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Dec 11, 2024 •
edited
Loading

Description

vs. floaty base units previously, which would cause upstream failures when sending the order:

Screenshot 2024-12-11 at 12 34 05

Issue (if applicable)

closes N/A, spotted in #8331 (review)

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

  • CoW limit orders execution is happy again

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • None

Screenshots (if applicable)

  • develop

https://jam.dev/c/4cf981c4-8d84-4e03-83c8-761b10aec9c0
Screenshot 2024-12-11 at 12 29 19

  • this diff
Screenshot 2024-12-11 at 12 33 05

@gomesalexandre gomesalexandre mentioned this pull request Dec 11, 2024
Merged
1 task
@gomesalexandre gomesalexandre marked this pull request as ready for review December 11, 2024 04:36
@gomesalexandre gomesalexandre requested a review from a team as a code owner December 11, 2024 04:36
woodenfurniture
woodenfurniture approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed any precision loss is negligible, geterin.

src/state/slices/limitOrderInputSlice/selectors.ts Show resolved Hide resolved
@woodenfurniture woodenfurniture merged commit dea6454 into develop Dec 11, 2024
1 check passed
@woodenfurniture woodenfurniture deleted the fix_buyAmount_baseUnit_0dp branch December 11, 2024 21:34
@gomesalexandre gomesalexandre mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodenfurniture woodenfurniture woodenfurniture approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomesalexandre @woodenfurniture