Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying the sample examples to refer v1beta1 #1352

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Modifying the sample examples to refer v1beta1 #1352

merged 1 commit into from
Oct 17, 2023

Conversation

apoorvajagtap
Copy link
Member

@apoorvajagtap apoorvajagtap commented Aug 8, 2023 •
edited
Loading

Changes

Fixes #1106 #1105

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Label for when a PR does not need a release note labels Aug 8, 2023
@openshift-ci openshift-ci bot requested review from HeavyWombat and qu1queee August 8, 2023 09:57
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign otaviof for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@apoorvajagtap apoorvajagtap force-pushed the BUILD-649 branch 2 times, most recently from 83ccf60 to 4e5aa30 Compare August 8, 2023 10:51
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 21, 2023
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 21, 2023
@apoorvajagtap apoorvajagtap changed the title [WIP] Modifying the sample examples to refer v1beta1 Modifying the sample examples to refer v1beta1 Aug 22, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2023
coreydaley
coreydaley suggested changes Aug 22, 2023
View reviewed changes
docs/buildrun.md Outdated Show resolved Hide resolved
docs/buildrun.md Outdated Show resolved Hide resolved
docs/buildrun.md Outdated Show resolved Hide resolved
@apoorvajagtap apoorvajagtap force-pushed the BUILD-649 branch 2 times, most recently from 4099ca3 to de22ae9 Compare August 23, 2023 07:36
@qu1queee qu1queee added this to the release-v0.12.0 milestone Aug 23, 2023
@qu1queee qu1queee mentioned this pull request Sep 4, 2023
Closed
@apoorvajagtap apoorvajagtap mentioned this pull request Sep 4, 2023
Closed
1 task
@coreydaley
Copy link
Contributor

/retest

SaschaSchwarze0
SaschaSchwarze0 requested changes Sep 6, 2023
View reviewed changes
samples/build/build_buildah_shipwright_managed_push_cr.yaml Outdated Show resolved Hide resolved
samples/build/build_buildah_strategy_managed_push_cr.yaml Outdated Show resolved Hide resolved
samples/build/build_kaniko-trivy-bad_cr.yaml Outdated Show resolved Hide resolved
samples/build/build_kaniko-trivy-good_cr.yaml Outdated Show resolved Hide resolved
samples/build/build_source-to-image_cr.yaml Outdated Show resolved Hide resolved
samples/buildstrategy/buildkit/buildstrategy_buildkit_cr.yaml Show resolved Hide resolved
samples/buildstrategy/kaniko/buildstrategy_kaniko-trivy_cr.yaml Outdated Show resolved Hide resolved
samples/buildstrategy/kaniko/buildstrategy_kaniko_cr.yaml Outdated Show resolved Hide resolved
samples/buildstrategy/source-to-image/buildstrategy_source-to-image-redhat_cr.yaml Outdated Show resolved Hide resolved
samples/buildstrategy/source-to-image/buildstrategy_source-to-image_cr.yaml Outdated Show resolved Hide resolved
SaschaSchwarze0
SaschaSchwarze0 requested changes Sep 6, 2023
View reviewed changes
docs/buildstrategies.md Outdated Show resolved Hide resolved
docs/buildrun.md Outdated Show resolved Hide resolved
docs/build.md Show resolved Hide resolved
docs/build.md Outdated Show resolved Hide resolved
docs/build.md Outdated Show resolved Hide resolved
docs/build.md Outdated Show resolved Hide resolved
docs/build.md Outdated Show resolved Hide resolved
docs/build.md Outdated Show resolved Hide resolved
docs/build.md Outdated Show resolved Hide resolved
docs/build.md Show resolved Hide resolved
@coreydaley
Copy link
Contributor

/kind documentation

@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 7, 2023
@coreydaley
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

New changes are detected. LGTM label has been removed.

@qu1queee qu1queee mentioned this pull request Sep 11, 2023
Closed
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2023
@apoorvajagtap apoorvajagtap mentioned this pull request Sep 26, 2023
Merged
4 tasks
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2023
@apoorvajagtap apoorvajagtap force-pushed the BUILD-649 branch 3 times, most recently from 7ab94f9 to a381f9d Compare October 13, 2023 10:12
@openshift-ci openshift-ci bot merged commit 92e7a0b into shipwright-io:main Oct 17, 2023
9 of 11 checks passed
@apoorvajagtap apoorvajagtap mentioned this pull request Oct 17, 2023
Closed
@christoph-jerolimov christoph-jerolimov mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeavyWombat HeavyWombat Awaiting requested review from HeavyWombat

@qu1queee qu1queee Awaiting requested review from qu1queee

@coreydaley coreydaley Awaiting requested review from coreydaley

@SaschaSchwarze0 SaschaSchwarze0 Awaiting requested review from SaschaSchwarze0

Assignees

@coreydaley coreydaley

Labels
kind/documentation Categorizes issue or PR as related to documentation. release-note-none Label for when a PR does not need a release note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Shipwright Overview
Archived in project
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.

[BETA API] Update sample build strategies, builds, and buildruns
5 participants
@apoorvajagtap @coreydaley @SaschaSchwarze0 @qu1queee @openshift-merge-robot