Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move localization button into the user menu #2922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josephmyers
Copy link
Collaborator

@josephmyers josephmyers commented Dec 19, 2024

This helps clean up the top bar. The localization button won't really be used after setting it once, possibly on the home page, before even seeing this button.

image


This change is Reviewable

@josephmyers josephmyers marked this pull request as ready for review December 19, 2024 03:30
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (1897259) to head (33be521).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2922   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files         533      533           
  Lines       31122    31122           
  Branches     5061     5066    +5     
=======================================
+ Hits        25161    25162    +1     
  Misses       5198     5198           
+ Partials      763      762    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nigel-wells
Copy link
Collaborator

The code looks fine. The only thing that bugs me is the arrow pointing to the right and then the sub-menu appears to the left - can we hide that or change it to something else?

@Nateowami
Copy link
Collaborator

Definitely going to want to talk about this one.

@josephmyers
Copy link
Collaborator Author

The code looks fine. The only thing that bugs me is the arrow pointing to the right and then the sub-menu appears to the left - can we hide that or change it to something else?

I absolutely looked into this. It appears that any programmatic fix has been labeled as "won't fix" -- angular/components#8402 (but I didn't look into it too much further)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants