Replace old MPSC/SPSC queues with JCTools #1413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jponge
added
enhancement
jponge
force-pushed
the
feat/use-jctools
branch
2 times, most recently
from
2725372 to
becbf47
Compare
jponge
changed the title
jponge
force-pushed
the
feat/use-jctools
branch
from
becbf47 to
a5fddc5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
============================================
- Coverage 89.37% 89.07% -0.30%
+ Complexity 3368 3268 -100
============================================
Files 459 456 -3
Lines 13454 13234 -220
Branches 1655 1640 -15
============================================
- Hits 12024 11788 -236
- Misses 794 805 +11
- Partials 636 641 +5
|
Closed
|
We can fix the JPMS issue with a release of JCTools: diff --git a/implementation/src/main/java/module-info.java b/implementation/src/main/java/module-info.java
index 13191b46..15f97369 100644
--- a/implementation/src/main/java/module-info.java
+++ b/implementation/src/main/java/module-info.java
@@ -1,7 +1,7 @@
open module io.smallrye.mutiny {
requires transitive io.smallrye.common.annotation;
- requires jctools.core;
+ requires org.jctools.core;
exports io.smallrye.mutiny;
exports io.smallrye.mutiny.converters.multi;
diff --git a/pom.xml b/pom.xml
index be9044f1..b2f4b8c6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -78,7 +78,7 @@
</modules>
<properties>
- <jctools-core.version>4.0.1</jctools-core.version>
+ <jctools-core.version>4.0.2-SNAPSHOT</jctools-core.version>
<mutiny-zero.version>1.0.0</mutiny-zero.version>
<reactive-streams.version>1.0.4</reactive-streams.version>
<rxjava3.version>3.1.8</rxjava3.version> |
|
Switched to our friendly fork at https://github.com/jponge/jct |
jponge
force-pushed
the
feat/use-jctools
branch
from
adfb7f1 to
3e63204
Compare
jponge
changed the title
- Refactored the Queues class and made all queue creations converge to it (except for tests). - Introduced Infrastructure#useUnsafeForQueues to decide when to use unpadded vs atomic variants. - Introduced native compilation smoke tests. Issue: #1330 BREAKING CHANGE: constants and methods have been removed from io.smallrye.mutiny.helpers.queues.Queues as well as previous MPSC/SPSC classes in the io.smallrye.mutiny.helpers.queues package.
jponge
force-pushed
the
feat/use-jctools
branch
from
3e63204 to
a6a9c9d
Compare
|
JCTools 4.0.2 has been released so we can go back to the upstream |
|
We will eventually go with the simplified PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1330
BREAKING CHANGE: constants and methods have been removed from io.smallrye.mutiny.helpers.queues.Queues
as well as previous MPSC/SPSC classes in the io.smallrye.mutiny.helpers.queues package.