Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutover to duckdb for unit tests #154

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Cutover to duckdb for unit tests #154

merged 3 commits into from
Dec 8, 2023

Conversation

dogversioning
Copy link
Contributor

This PR does the following:

  • Removes athena based cursor mocking in favor of duckDB for CLI testing
    • athena is still covered by our regression environment
  • Adds a simple test for the core study (and validation data)
  • Some light tweaks to some of the mock studies to make more sense being run in a real db
  • Clears env for the duckdb test to prevent overriding behavior

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added
  • Run pylint if you're making changes beyond adding studies
  • Update template repo if there are changes to study configuration

tests/test_cli.py Outdated Show resolved Hide resolved
tests/test_cli.py Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
tests/test_core.py Outdated Show resolved Hide resolved
@dogversioning dogversioning merged commit 77eeca5 into main Dec 8, 2023
3 checks passed
@dogversioning dogversioning deleted the mg/unit_test_duckdb branch December 8, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants