Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: drop 2016 cutoff from core tables #304

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Oct 3, 2024

Fixes #301

Checklist

  • Consider if documentation in docs/ needs to be updated
    • If you've changed the structure of a table, you may need to run generate-md
    • If you've added/removed core study fields that not in US Core, update our list of those in core-study-details.md
  • Consider if tests should be added
  • Update template repo if there are changes to study configuration in manifest.toml

@mikix mikix force-pushed the mikix/drop-2016-cutoff branch from d35b17a to 17dcf66 Compare October 3, 2024 18:48
@mikix mikix marked this pull request as ready for review October 3, 2024 18:49
Copy link

github-actions bot commented Oct 3, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2240 2228 99% 90% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: d9d9ce4 by action🐍

@mikix mikix force-pushed the mikix/drop-2016-cutoff branch from 17dcf66 to d9d9ce4 Compare October 3, 2024 19:22
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file proves that the other regression updates are alright - we didn't have the 2016 cutoff on the MedicationRequest resource for some reason (maybe it lost it in the refactors or it never had it).

And the only changes here are different quoting.

@mikix mikix merged commit 4502da8 into main Oct 3, 2024
3 checks passed
@mikix mikix deleted the mikix/drop-2016-cutoff branch October 3, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2016 filtering is still present
2 participants