Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gas fee staleness threshold configurable per chain #1491

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Make gas fee staleness threshold configurable per chain #1491

merged 2 commits into from
Oct 11, 2024

Conversation

RyanRHall
Copy link
Contributor

Motivation

On some chains, it is possible the gas price will just always be zero or will be fixed at some constant fee

Solution

Make stalenessThreshold per dest chain and have 0 mean no staleness check

@RyanRHall RyanRHall requested review from makramkd, elatoskinas, RayXpub and a team as code owners October 7, 2024 19:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

LCOV of commit 8518067 during Solidity Foundry #8561

Summary coverage rate:
  lines......: 97.9% (2283 of 2333 lines)
  functions..: 95.1% (429 of 451 functions)
  branches...: 93.6% (539 of 576 branches)

Files changed coverage rate: n/a

@RyanRHall RyanRHall force-pushed the CCIP-3414-make-staleness-threshold-per-chain-in-fee-quoter branch from 8a84895 to cf36175 Compare October 8, 2024 17:13
@RyanRHall RyanRHall requested a review from RensR October 8, 2024 17:24
@RyanRHall RyanRHall force-pushed the CCIP-3414-make-staleness-threshold-per-chain-in-fee-quoter branch from ec16722 to 843059f Compare October 9, 2024 14:26
@RyanRHall RyanRHall requested a review from RensR October 10, 2024 13:54
@RyanRHall RyanRHall force-pushed the CCIP-3414-make-staleness-threshold-per-chain-in-fee-quoter branch from 8cc634a to 8518067 Compare October 10, 2024 21:21
@RyanRHall RyanRHall enabled auto-merge (squash) October 10, 2024 21:30
@RyanRHall RyanRHall requested a review from RayXpub October 10, 2024 21:31
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@RyanRHall RyanRHall merged commit 2d5ff29 into ccip-develop Oct 11, 2024
126 of 127 checks passed
@RyanRHall RyanRHall deleted the CCIP-3414-make-staleness-threshold-per-chain-in-fee-quoter branch October 11, 2024 05:53
@RyanRHall RyanRHall mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RayXpub RayXpub RayXpub approved these changes

@RensR RensR RensR approved these changes

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanRHall @RensR @RayXpub