Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nonspecific search engine bug fix and unit test #2453

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

trishorts
Copy link
Contributor

@trishorts trishorts commented Dec 13, 2024

non-specific search engine has a bug where a second modification is attempted to be added to a peptide with set mods where there is an existing modification at that position. This PR adds a check that prevents addition of the second mod.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.87%. Comparing base (a06bc0d) to head (94c7354).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2453      +/-   ##
==========================================
+ Coverage   93.82%   93.87%   +0.04%     
==========================================
  Files         142      142              
  Lines       22008    22008              
  Branches     3014     3014              
==========================================
+ Hits        20648    20659      +11     
+ Misses        910      903       -7     
+ Partials      450      446       -4     
Files with missing lines Coverage Δ
...cificEnzymeSearch/NonSpecificEnzymeSearchEngine.cs 88.95% <100.00%> (+1.47%) ⬆️

... and 1 file with indirect coverage changes

@trishorts trishorts changed the title bug fix and unit test nonspecific search engine bug fix and unit test Dec 13, 2024
@nbollis nbollis linked an issue Dec 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash mid run of a small DB
3 participants