fix: unit test

sofastack · Sep 28, 2023 · c5fdd1f · c5fdd1f
1 parent 8b14d26
commit c5fdd1f
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/module-controller/internal/controller/moduledeployment_controller.go b/module-controller/internal/controller/moduledeployment_controller.go
@@ -119,6 +119,12 @@ func (r *ModuleDeploymentReconciler) Reconcile(ctx context.Context, req ctrl.Req
 				return ctrl.Result{}, err
 			}
 		}
+		if !moduleVersionChanged && isUrlChange(moduleDeployment.Spec.Template.Spec.Module, newRS.Spec.Template.Spec.Module) {
+			newRS.Spec.Template.Spec.Module = moduleDeployment.Spec.Template.Spec.Module
+			if err := r.Client.Update(ctx, newRS); err != nil {
+				return ctrl.Result{}, err
+			}
+		}
 	case moduledeploymentv1alpha1.ModuleDeploymentReleaseProgressWaitingForConfirmation:
 		moduleDeployment.Spec.Pause = true
 		if err := r.Update(ctx, moduleDeployment); err != nil {
@@ -137,12 +143,6 @@ func (r *ModuleDeploymentReconciler) Reconcile(ctx context.Context, req ctrl.Req
 			}
 		}
 	}
-	if !moduleVersionChanged && isUrlChange(moduleDeployment.Spec.Template.Spec.Module, newRS.Spec.Template.Spec.Module) {
-		newRS.Spec.Template.Spec.Module = moduleDeployment.Spec.Template.Spec.Module
-		if err := r.Client.Update(ctx, newRS); err != nil {
-			return ctrl.Result{}, err
-		}
-	}
 
 	// update moduleDeployment owner reference
 	err = r.updateOwnerReference(ctx, moduleDeployment)