Dev skip project compilation #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozenfrank
commented
Apr 24, 2024
| @@ -112,6 +89,45 @@ public void run() { | |||
| } | |||
| } | |||
|
|
|||
| private Map<String, Rubric.Results> evaluateProject(RubricConfig rubricConfig) throws GradingException { | |||
| // NOTE: Ideally these would be treated with enum types. That will need to be improved with #300. | |||
There was a problem hiding this comment.
Note that there is still lots of room for improvement as in #300, but this is only a lightweight adjustment for now.
pawlh
approved these changes
Apr 24, 2024
frozenfrank
force-pushed
the
dev-skip-project-compilation
branch
from
4458f15 to
fc4cb67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor adjustment gives DEV's the ability to skip compilation of projects as needed. In the process, I also broke the existing code into smaller functions which allows us to skip part of their functionality.
I'm currently using this to test #233 since I'm not interested in the actual grading results, and future dev's may want this option as well.
Ideally, there would exist a bank of options that allow developers the ability to skip any combination of the project evaluation based on their particular project. Ideally, those options would be available in some config object or ENV variable or command line option. However, since we don't have a whole system set up yet, this is only a lightweight adjustment to provide this functionality via a hard-coded local variable.