Remove Server's dependency on Controller classes

[ThanGerlek]

Introduces an EndpointProvider interface which Server now uses for all its endpoint calls. Also extracts startup logic (getOptions, initializeDaos, etc) out of the Server class and into a Main class.

Warning

This moves the location of the main() method (from java/server/Server.java to java/Main.java). Existing run configurations will likely break and will need to be updated.

[ThanGerlek]

@19mdavenport Since this moves the main() method into a different file, how will this affect the existing deployment system? Does anything else need to happen?

The good news is that it's now in a dedicated Main class, so it will probably never need to move again.

[webecke]

LGTM!

Seems like a clean solution to make things more independent of each other and more flexible. It does look like adding new endpoints now requires a little more work, but its marginal so I'm not too worried about it. Great work!

[19mdavenport]

Could you fix the main class configuration in pom.xml?

[ThanGerlek]

I've updated mainClass, is that all that needs to happen?

Sorry, I know absolutely nothing about Maven 😅

[19mdavenport]

I think so, you could try testing this by running mvn exec:java in the base directory and seeing if the server starts normally.

[19mdavenport]

Also, did you commit/push that update?

[ThanGerlek]

Yes, but in the wrong branch. RIP.

[frozenfrank]

`git rebase —onto NEW_BRANCH HEAD^`

…

On Thu, Nov 21, 2024 at 12:18 PM Nathaniel Gerlek ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/main/java/Main.java <#479 (comment)> : > +import edu.byu.cs.service.SubmissionService; +import edu.byu.cs.util.ResourceUtils; +import org.apache.commons.cli.*; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.File; +import java.io.IOException; +import java.util.Properties; + +public class Main { + private static Logger LOGGER = LoggerFactory.getLogger(Main.class); + + private static EndpointProvider endpointProvider = new EndpointProviderImpl(); + + public static void main(String[] args) { Yes, but in the wrong branch. RIP. — Reply to this email directly, view it on GitHub <#479 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEXEBOCQ45CVU3J3GJPZXAD2BYWZ7AVCNFSM6AAAAABRZM3QRSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINJSGQYTSNZRGM> . You are receiving this because your review was requested.Message ID: ***@***.***>

[frozenfrank]

`git checkout CORRECT_BRANCH; git cherry-pick -x CORRECT_COMMIT`

…

On Thu, Nov 21, 2024 at 12:20 PM James ***@***.***> wrote: `git rebase —onto NEW_BRANCH HEAD^` On Thu, Nov 21, 2024 at 12:18 PM Nathaniel Gerlek < ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In src/main/java/Main.java > <#479 (comment)> > : > > > +import edu.byu.cs.service.SubmissionService; > +import edu.byu.cs.util.ResourceUtils; > +import org.apache.commons.cli.*; > +import org.slf4j.Logger; > +import org.slf4j.LoggerFactory; > + > +import java.io.File; > +import java.io.IOException; > +import java.util.Properties; > + > +public class Main { > + private static Logger LOGGER = LoggerFactory.getLogger(Main.class); > + > + private static EndpointProvider endpointProvider = new EndpointProviderImpl(); > + > + public static void main(String[] args) { > > Yes, but in the wrong branch. RIP. > > — > Reply to this email directly, view it on GitHub > <#479 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEXEBOCQ45CVU3J3GJPZXAD2BYWZ7AVCNFSM6AAAAABRZM3QRSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINJSGQYTSNZRGM> > . > You are receiving this because your review was requested.Message ID: > ***@***.*** > com> >

[ThanGerlek]

@19mdavenport Apparently mvn exec:java doesn't work for me (I get this error message (although the listed solutions don't fix it for me), even on the main branch in a dev container), so someone other than me might need to test that. Obviously it does pass our CI/CD tests but I assume they have a different execution path