Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move punctuation to i18n.csv #240

Merged
merged 6 commits into from
Apr 7, 2024
Merged

Conversation

Schokobecher
Copy link
Contributor

This should close #236

Changes:

  • Moved hard-coded punctuation to i18n.csv
  • Three dots instead of two (ellipsis typically have three)
  • Added another string called _L_DELETE_FILE for use in FILE_BROWSER_MENU_REMOVE_FOLDER
  • Updated the translations for _L_DELETE_FILE accordingly, please check if zh_Hans and zh_TW are useable
  • Rebuilt language files

I compiled and flashed this version, and English/German look correct. Let me know if anything needs to be reworked, or I missed anything!

Copy link
Owner

@solosky solosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments.
Thanks for your contributions.

@solosky solosky merged commit 47d6008 into solosky:develop Apr 7, 2024
2 checks passed
@solosky solosky mentioned this pull request Apr 7, 2024
MayanKoyote added a commit to MayanKoyote/pixl.js that referenced this pull request Apr 7, 2024
@MayanKoyote
Copy link
Contributor

IMG_3491

What if to use:
for header text - line [_L_APP_AMIIDB_TIPS], its content is: 'Confirm' in English, 'Hint' in Simplified Chinese, 'Attention' in Russian.
for confirmation button text - line [_L_CONFIRM], its content is: 'Confirm' in English, 'Sure' in Simplified Chinese, 'Yes' in Russian.
?

@impeeza
Copy link
Contributor

impeeza commented Apr 7, 2024

Hello there, @solosky Should we then use on the CSV file the ellipsis character instead of the three dots?

for roman alphabet there is the Unicode Character «…» (U+2026); and as far I know, (for this please correct me) for Chinese, Unicode provides an explicitly centered U+22EF «⋯» MIDLINE HORIZONTAL ELLIPSIS character

that's OK or better to use the traditional dots?

@Schokobecher
Copy link
Contributor Author

I agree with @MayanKoyote three "Delete" on one screen is a bit much, at least the button should be _L_CONFIRM

@impeeza I would prefer the Unicode version as its spacing is smaller compared to just regular dots. Both are included in wenquanyi_9pt_u8g2.bdf so it should be a drop-in replacement.

@Schokobecher Schokobecher deleted the ellipsis branch April 7, 2024 22:49
@impeeza
Copy link
Contributor

impeeza commented Apr 11, 2024

Hello there, @Schokobecher which one is the unicode version? I will like to try it on my branch before post a update

@Schokobecher
Copy link
Contributor Author

@impeeza It's the one you posted, U+2026 and U+22EF are both provided by the font

@impeeza
Copy link
Contributor

impeeza commented Apr 12, 2024

I was making some test and seems the FONT uses the same drawing for the ellipsis both are draw as tree dots on the middle of the vertical space look the custom created firmware:

image

image

image

my test file is on the branch ellipsis of my fork:

https://github.com/impeeza/pixl.js/blob/impeeza-Ellipsis/fw/data/i18n.csv

as you can see on the Chinese languages I use U+22EF and for the rest of languages U+2026 but on the device both are similar.

U+22EF is like three dots
image

U+2026 is like three small dashes.
image

@impeeza
Copy link
Contributor

impeeza commented Apr 12, 2024

By the way I am very pro to use the Unicode character for ellipsis instead of three separated dots

@MayanKoyote
Copy link
Contributor

MayanKoyote commented Apr 12, 2024

It's already have been discussed:
#208
So either look for other already-made ellipses in the font, or look for an empty space (if there is one) intended for one of the possible ellipsis variants (so as not to spoil the font with gags) and draw the symbol yourself.

btw, check this one:
U+2026 (Horizontal Ellipsis) redrawn as it should be (I hope so), U+22EF (Midline Horizontal Ellipsis) left as is.
wenquanyi_9pt_u8g2-u2026.zip

IMG_3540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants