-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move punctuation to i18n.csv #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comments.
Thanks for your contributions.
Hello there, @solosky Should we then use on the CSV file the ellipsis character instead of the three dots? for roman alphabet there is the Unicode Character «…» (U+2026); and as far I know, (for this please correct me) for Chinese, Unicode provides an explicitly centered U+22EF «⋯» MIDLINE HORIZONTAL ELLIPSIS character that's OK or better to use the traditional dots? |
I agree with @MayanKoyote three "Delete" on one screen is a bit much, at least the button should be @impeeza I would prefer the Unicode version as its spacing is smaller compared to just regular dots. Both are included in |
Hello there, @Schokobecher which one is the unicode version? I will like to try it on my branch before post a update |
@impeeza It's the one you posted, U+2026 and U+22EF are both provided by the font |
I was making some test and seems the FONT uses the same drawing for the ellipsis both are draw as tree dots on the middle of the vertical space look the custom created firmware: my test file is on the branch ellipsis of my fork: https://github.com/impeeza/pixl.js/blob/impeeza-Ellipsis/fw/data/i18n.csv as you can see on the Chinese languages I use U+22EF and for the rest of languages U+2026 but on the device both are similar. |
By the way I am very pro to use the Unicode character for ellipsis instead of three separated dots |
It's already have been discussed: btw, check this one: |
This should close #236
Changes:
_L_DELETE_FILE
for use inFILE_BROWSER_MENU_REMOVE_FOLDER
_L_DELETE_FILE
accordingly, please check if zh_Hans and zh_TW are useableI compiled and flashed this version, and English/German look correct. Let me know if anything needs to be reworked, or I missed anything!