Upgrade github workflow upload-artifact@v3 to @v4. #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upload-artifact@v3 will be deprecate in Jan 2025. Find more details here: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
|
As a side benefit, the OTA zip can now be downloaded individually. |
|
The only slight annoyance is that the all-in-one merged archive may be a bit harder to locate among all the other files. It's named |
|
Hi there, Thank your PR on the workflow, I already completed the workflow update on neo branch, I may cherry pick to the develop branch when I am avaliable. |
|
Meanwhile, app like iNFC and MToolsBLE already adopted current build artifact layout, we would better do not change the final artifact layout, at least make it capatible. |
…ge make sure the user will be backed out of the screen when that happens, instead of being permanently stuck on the naming screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upload-artifact@v3will be deprecate in Jan 2025. Find more details here: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md