Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade github workflow upload-artifact@v3 to @v4. #294

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Upgrade github workflow upload-artifact@v3 to @v4. #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27dba11
Upgrade github workflow upload-artifact@v3 to @v4.
Nov 29, 2024
d4773e2
Renaming an uninitialized card chemeleon card always fails. This chan…
Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions .github/workflows/pixl.js-fw.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,32 +26,37 @@ jobs:
- name: build firmware
run: cd fw && make all RELEASE=1 APP_VERSION=$GITHUB_RUN_NUMBER BOARD=${{matrix.board}}
- name: upload bootloader
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pixljs_fw_${{matrix.board}}
name: ${{matrix.board}}__bootloader.hex
path: fw/_build/bootloader.hex
- name: upload firmware
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pixljs_fw_${{matrix.board}}
name: ${{matrix.board}}__pixljs.hex
path: fw/_build/pixljs.hex
- name: upload all
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pixljs_fw_${{matrix.board}}
name: ${{matrix.board}}__pixljs_all.hex
path: fw/_build/pixljs_all.hex
- name: upload ota
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pixljs_fw_${{matrix.board}}
name: ${{matrix.board}}__pixjs_ota_v${{github.run_number}}.zip
path: fw/_build/pixjs_ota_v${{github.run_number}}.zip
- name: upload fw update script
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pixljs_fw_${{matrix.board}}
name: ${{matrix.board}}__fw_update.bat
path: fw/scripts/fw_update.bat
- name: upload fw readme file
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pixljs_fw_${{matrix.board}}
path: fw/docs/fw_readme.txt
name: ${{matrix.board}}__fw_readme.txt
path: fw/docs/fw_readme.txt
- name: Merge Artifacts
uses: actions/upload-artifact/merge@v4
with:
name: ${{matrix.board}}__pixljs_fw_${{github.run_number}}
pattern: ${{matrix.board}}__*
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,5 @@ hw/LIPO.RevA

dist
# venv stuff
.venv
.venv
*.un~
1 change: 1 addition & 0 deletions fw/application/src/app/chameleon/scene/chameleon_scene_menu_card_set_name.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ static void chameleon_scene_menu_card_set_name_text_input_event_cb(mui_text_inpu
int32_t err = tag_helper_set_nickname(text);
if (err != 0) {
mui_toast_view_show(app->p_toast_view, _T(APP_CHAMELEON_CARD_SET_NICK_FAILED));
mui_scene_dispatcher_previous_scene(app->p_scene_dispatcher);
return;
}
mui_toast_view_show(app->p_toast_view, _T(APP_CHAMELEON_CARD_SET_NICK_SUCCESS));
Expand Down