Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Extract definition stuff from collection.go #2706

Merged
merged 5 commits into from
Jun 10, 2024

Extract definition validation to validation file

55de3b5
Select commit
Loading
Failed to load commit list.
Merged

refactor: Extract definition stuff from collection.go #2706

Extract definition validation to validation file
55de3b5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 10, 2024 in 1s

77.85% (-0.10%) compared to 8d0c756

View this Pull Request on Codecov

77.85% (-0.10%) compared to 8d0c756

Details

Codecov Report

Attention: Patch coverage is 82.99817% with 93 lines in your changes missing coverage. Please review.

Project coverage is 77.85%. Comparing base (8d0c756) to head (55de3b5).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2706      +/-   ##
===========================================
- Coverage    77.95%   77.85%   -0.10%     
===========================================
  Files          308      310       +2     
  Lines        23125    23125              
===========================================
- Hits         18025    18002      -23     
- Misses        3715     3731      +16     
- Partials      1385     1392       +7     
Files Coverage Δ
internal/db/collection.go 71.84% <ø> (-5.89%) ⬇️
internal/db/definition_validation.go 93.60% <93.60%> (ø)
internal/db/schema.go 80.75% <73.87%> (-4.96%) ⬇️
internal/db/collection_define.go 74.19% <74.19%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0c756...55de3b5. Read the comment docs.