Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i): Aggregate filter returns one result #3316

Merged
merged 1 commit into from
Dec 11, 2024

fix and add tests

e3b15bc
Select commit
Loading
Failed to load commit list.
Merged

fix(i): Aggregate filter returns one result #3316

fix and add tests
e3b15bc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 11, 2024 in 1s

78.11% (+0.03%) compared to 648924e

View this Pull Request on Codecov

78.11% (+0.03%) compared to 648924e

Details

Codecov Report

Attention: Patch coverage is 90.95607% with 35 lines in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (648924e) to head (e3b15bc).

Files with missing lines Patch % Lines
internal/planner/average.go 75.00% 6 Missing and 2 partials ⚠️
internal/planner/max.go 92.79% 6 Missing and 2 partials ⚠️
internal/planner/min.go 92.79% 6 Missing and 2 partials ⚠️
internal/planner/count.go 88.00% 4 Missing and 2 partials ⚠️
internal/planner/sum.go 93.98% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3316      +/-   ##
===========================================
+ Coverage    78.08%   78.11%   +0.03%     
===========================================
  Files          382      382              
  Lines        35412    35448      +36     
===========================================
+ Hits         27651    27688      +37     
+ Misses        6123     6121       -2     
- Partials      1638     1639       +1     
Files with missing lines Coverage Δ
internal/planner/sum.go 85.05% <93.98%> (-0.94%) ⬇️
internal/planner/count.go 93.13% <88.00%> (-1.99%) ⬇️
internal/planner/average.go 82.19% <75.00%> (-2.66%) ⬇️
internal/planner/max.go 90.50% <92.79%> (-1.36%) ⬇️
internal/planner/min.go 90.50% <92.79%> (-1.36%) ⬇️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648924e...e3b15bc. Read the comment docs.