Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added visualize.cpp to visualize chessboard corners and updated CMakeLists.txt accordingly… #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BarunKGP
Copy link

Added visualize.cpp to visualize chessboard corners and updated CMakeLists.txt accordingly. Please review the changes made @sourishg

@sourishg
Copy link
Owner

Hi @BarunKGP - you don't need to create an extra file visualize.cpp to solve this issue. Just incorporate your visualization code in calib_intrinsic.cpp.

@BarunKGP
Copy link
Author

@sourishg , I've updated calib_stereo.cpp in the latest commit. It now contains code to visualize the stereo pair if both left and right images are found.

@mpdmanash
Copy link
Collaborator

Hi @BarunKGP, great.
Here are some of views:

  • To enable the visualization, please use some other popt variable than v, as it is already used for rightcalib_file option.
  • Use POPT_ARG_NONE as the type of your variable as it does not need an argument. Here is an excerpt from popt documentations that might help you:

If the argInfo argument type is POPT_ARG_NONE, the popt library will set arg to 1 if the option is present on the command line. You should pass a pointer to an int if you want this set for you.

  • imshow, would also need a waitKey(0) after it for the image to be actually displayed. However, it would also need the user to press a key after every frame. You can find out a way to make it more user friendly.

@sourishg
Copy link
Owner

@BarunKGP please update the PR as requested by @ManashRaja

@BarunKGP
Copy link
Author

Yes, sure! I'm working on it. Will update it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants