BUG: Recreate JWST MJD-OBS if it is missing

[pllim]

Description

This pull request is to recreate missing MJD-OBS for JWST data so it will load into Cubeviz.

Proper GWCS support is not possible currently due to glue-viz/glue-astronomy#59 (the cube would load but it chokes on 1D spectrum part).

With this patch:

Fixes #690

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a change log needed? If yes, is it added to CHANGES.rst?
• Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[codecov]

Codecov Report

Attention: Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review.

Project coverage is 72.45%. Comparing base (f26a213) to head (bb753f7).
Report is 2827 commits behind head on main.

Files	Patch %	Lines
jdaviz/configs/cubeviz/plugins/parsers.py	4.54%	21 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
- Coverage   72.63%   72.45%   -0.19%     
==========================================
  Files          74       74              
  Lines        5576     5590      +14     
==========================================
  Hits         4050     4050              
- Misses       1526     1540      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pllim]

The missing coverage is because I don't have permission to include the original offending data file into unit test. I can add one more test here with dummy header but I am not if it is worth it. What do you think?

[ibusko]

This looks good and works well!

[havok2063]

This looks good to me. When I tested it locally, the ERR and DQ extensions do not load in Cubeviz for me. I remember this problem from before and I thought we fixed it? In any case that is a separate issue than this one.

If we already have the framework for testing against fake files, then I might add some tests for this. But if it's a lot of extra work to create that framework, then I'm ok not having those tests.

[pllim]

Re: ERR and DQ -- I think they stopped working after #547 (transition from spectral-cube to specutils). I can see if I can make them load without too much extra code here.

Re: tests -- AFAIK, this is the only thing being tested in the tests for Cubeviz parser. In this patch, I already removed MJD-OBS from it to mimic your problem (though I didn't add in OBSGEO). A more proper way to test is to make fake small test files to ship with the test suite but I am afraid it will be more involved and probably out of scope here.

jdaviz/jdaviz/configs/cubeviz/plugins/tests/test_parsers.py

Line 10 in f26a213

def image_hdu_obj():

[pllim]

Too late for your test data (i.e., we still need this workaround for now) but Nadia put a patch to astropy at astropy/astropy#12598 . FYI.

[pllim]

"latest dev" job failure is unrelated. Looks like something changed upstream:

ERROR: No matching distribution found for asdf-astropy

[pllim]

@havok2063 , can you please review again? All the extensions you care about should load now.

[havok2063]

Tested again. All looks good to me.