Small bug in TinyMCE's template plugin #100
Conversation
Using TinyMCE's template plugin, I tried to insert a snippet where the outmost tag was a DIV with a class:
<div class="ym-grid">
<div class="ym-g50 ym-gl">
<div class="ym-gbox">
<p>Content of the left column</p>
</div>
</div>
<div class="ym-g50 ym-gr">
<div class="ym-gbox">
<p>Content of the right column</p>
</div>
</div>
</div>
After adding it, only the outmost DIV was inserted, the other elements just disappeared.
I found out that this happened because my template_selected_content_classes list was empty. In the jscripts\tiny_mce\plugins\template\editor_plugin_src.js there needs to be a test if it is empty before replacing, otherwise every time a construct like this is inserted, the inner HTML will be replaced (with the empty string if nothing is selected in the editor).
IMPORTANT: Since the minified editor_plugin.js is used instead of the editor_plugin_src.js, both files should be renamed so that the editor_plugin_src.js is then the editor_plugin.js. I'll try to submit this fix to the TinyMCE repository as well; hopefully there'll be a fixed minified version, too.
Signed-off-by: Jan-Christoph Ihrens <[email protected]>
|
Hi @enigmatic-user we are preparing an update for TinyMCE over at the new modxcms/TinyMCE location. Did you rename the files you mentioned in your commit? |
|
Hi @jpdevries, sorry, can you help me a bit? I posted this three months ago, so I don't remember every single step... Is there a problem with the commit? IIRC, there are two files, editor_plugin.js and editor_plugin_src.js. Since editor_plugin.js is minified, I modified the readable editor_plugin_src.js and then renamed it to editor_plugin.js since this is the file that is actually used. Of course you can instead use the new editor_plugin_src.js to create a minified editor_plugin.js. Does this answer your question? Cheers, |
|
@enigmatic-user That does make sense. No problem with the commit. I will look into minifying that JavaScript file accordingly and should have a 4.3.4-beta1 to test soon. Thanks! |
|
@jpdevries: Great, I'm looking forward to the beta release! I still have to switch all my forks of splittingred's repositories to the new locations. Or is Shaun still maintaining some of his packages? |
|
You’ll want to switch the forks to modxcms/TinyMCE. All spittingred Extras are maintained there JP DeVries On Tuesday, December 17, 2013 at 12:29 PM, Jan-Christoph Ihrens wrote:
|
I encountered the following bug:
Using TinyMCE's template plugin, I tried to insert a snippet where the outmost tag was a DIV with a class:
After adding it, only the outmost DIV was inserted, the other elements just disappeared.
I found out that this happened because my template_selected_content_classes list was empty. In the jscripts\tiny_mce\plugins\template\editor_plugin_src.js there needs to be a test if it is empty before replacing, otherwise every time a construct like this is inserted, the inner HTML will be replaced (with the empty string if nothing is selected in the editor).
IMPORTANT: Since the minified editor_plugin.js is used instead of the editor_plugin_src.js, both files should be renamed so that the editor_plugin_src.js is then the editor_plugin.js. I'll try to submit this fix to the TinyMCE repository as well; hopefully there'll be a fixed minified version, too.