Commits on Sep 22, 2013

1. I encountered the following bug: …

   Using TinyMCE's template plugin, I tried to insert a snippet where the outmost tag was a DIV with a class:
   
   <div class="ym-grid">
       <div class="ym-g50 ym-gl">
           <div class="ym-gbox">
               <p>Content of the left column</p>
           </div>
       </div>
       <div class="ym-g50 ym-gr">
           <div class="ym-gbox">
               <p>Content of the right column</p>
           </div>
       </div>
   </div>
   
   After adding it, only the outmost DIV was inserted, the other elements just disappeared.
   
   I found out that this happened because my template_selected_content_classes list was empty. In the jscripts\tiny_mce\plugins\template\editor_plugin_src.js there needs to be a test if it is empty before replacing, otherwise every time a construct like this is inserted, the inner HTML will be replaced (with the empty string if nothing is selected in the editor).
   
   IMPORTANT: Since the minified editor_plugin.js is used instead of the editor_plugin_src.js, both files should be renamed so that the editor_plugin_src.js is then the editor_plugin.js. I'll try to submit this fix to the TinyMCE repository as well; hopefully there'll be a fixed minified version, too.
   
   Signed-off-by: Jan-Christoph Ihrens <[email protected]>

   

   enigmatic-user committed Sep 22, 2013
   Configuration menu

   • View commit details
   • Copy full SHA for f1882fb
   • Browse repository at this point

   Copy the full SHA

   f1882fb View commit details

   Browse the repository at this point in the history