Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix var naming in Python #2530

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Fix var naming in Python #2530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d781b98
python: hpp::fcl:: -> coal::
jcarpent Dec 23, 2024
116dfb9
changelog: sync
jcarpent Dec 23, 2024
81b145e
python: hpp::fcl:: -> coal::
jcarpent Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

### Fixed
- Fix mjcf Euler angle parsing: use xyz as a default value for eulerseq compiler option ([#2526](https://github.com/stack-of-tasks/pinocchio/pull/2526))
- Fix variable naming in Python ([#2530](https://github.com/stack-of-tasks/pinocchio/pull/2530))

## [3.3.1] - 2024-12-13

Expand Down
6 changes: 3 additions & 3 deletions include/pinocchio/bindings/python/collision/broadphase-manager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright (c) 2022 INRIA
// Copyright (c) 2022-2024 INRIA
//

#ifndef __pinocchio_python_collision_broadphase_manager_hpp__
Expand Down Expand Up @@ -62,10 +62,10 @@ namespace pinocchio
static void expose()
{
std::string derived_name = boost::typeindex::type_id<Derived>().pretty_name();
boost::algorithm::replace_all(derived_name, "hpp::fcl::", "");
boost::algorithm::replace_all(derived_name, "coal::", "");
const std::string class_name = "BroadPhaseManager_" + derived_name;

const std::string class_doc = "Broad phase manager associated to hpp::fcl::" + derived_name;
const std::string class_doc = "Broad phase manager associated to coal::" + derived_name;
bp::class_<Self> registered_class(class_name.c_str(), class_doc.c_str(), bp::no_init);
registered_class.def(BroadPhaseManagerPythonVisitor());

Expand Down
6 changes: 3 additions & 3 deletions include/pinocchio/bindings/python/collision/tree-broadphase-manager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright (c) 2022 INRIA
// Copyright (c) 2022-2024 INRIA
//

#ifndef __pinocchio_python_collision_tree_broadphase_manager_hpp__
Expand Down Expand Up @@ -49,11 +49,11 @@ namespace pinocchio
static void expose()
{
std::string derived_name = boost::typeindex::type_id<Derived>().pretty_name();
boost::algorithm::replace_all(derived_name, "hpp::fcl::", "");
boost::algorithm::replace_all(derived_name, "coal::", "");
const std::string class_name = "TreeBroadPhaseManager_" + derived_name;

const std::string class_doc =
"Tree-based broad phase manager associated to hpp::fcl::" + derived_name;
"Tree-based broad phase manager associated to coal::" + derived_name;
bp::class_<Self> registered_class(class_name.c_str(), class_doc.c_str(), bp::no_init);
registered_class.def(TreeBroadPhaseManagerPythonVisitor());

Expand Down
Loading