-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile & Feature Installation instructions #133
Makefile & Feature Installation instructions #133
Conversation
Converted to draft until I fix the CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I was able to build it successfully following the readme. Just needed to update my CommandLineTools and Node.js (Got clear errors)
677c130
to
c42e554
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works on my machine 👍
Though one annoying point: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The makefile commands work as expected and are helpful.
One note is that, with pnpm
, the package-lock.json
files shouldn't be being updated (and should be deleted actually). That could indicate you're using both npm install
and pnpm install
. The pnpm-lock.yaml
file at the root of the workspace acts as the lockfile for all workspace packages.
|
||
- run: cargo test | ||
- name: Run tests | ||
run: make test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just update this Github workflow to be something like "Run tests", since this will run both rust and JS tests? I'd be fine with that, and if there are Rust / Contract / etc workflows we want separately we can do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll change this to just be run tests
and keep the contracts one because it looks like it does more than just this does. Ideally these wouldn't need to be separate because GitHub workflowss aren't really for testing, they're for preventing regression, and so long as the workflow is blocked when we mess something and we cursorily know why then we're good.
If you try committing that change locally and then rerunning |
@netrome if you run |
Ah, yeah the current |
I've opened #135 which should prevent accidental usage of different PNPM versions |
c42e554
to
8a966f8
Compare
8a966f8
to
43db88b
Compare
Use the following template to create your pull request
Description
emily-operation-lambda
->emily-lambda
, etc.build.rs
file.Makefile
with some emily related commands and general build command.Note that the
Makefile
is not complete with all the tools for all the monorepo packages. We should update theMakefile
with the commands necessary to develop for the packages as we go.