-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile & Feature Installation instructions #133
Merged
AshtonStephens
merged 4 commits into
main
from
100-feature-installation-instructions-for-build-dependencies-in-readmemd
May 8, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4b11699
feat: Update package names and build commands
AshtonStephens f6e3f99
feat: Basic Makefile with Emily Commands
AshtonStephens 6219e0a
feat: Readme with updated installation and make commands.
AshtonStephens 43db88b
feat: Update CI workflows to use Makefile
AshtonStephens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
install: | ||
pnpm install | ||
|
||
build: install | emily-client | ||
cargo build \ | ||
&& pnpm --recursive build | ||
|
||
test: install | emily-client | ||
cargo test \ | ||
&& pnpm --recursive test | ||
|
||
lint: install | emily-client | ||
cargo clippy \ | ||
&& pnpm --recursive run lint | ||
|
||
clean: | ||
cargo clean \ | ||
&& pnpm --recursive clean | ||
|
||
# Emily API | ||
# ---------------------------------------------------- | ||
|
||
EMILY_PATH=emily | ||
EMILY_API_PROJECT_NAME=emily-api | ||
EMILY_CDK_PROJECT_NAME=emily-cdk | ||
|
||
emily-cdk: emily-client | emily-lambda | ||
pnpm --filter $(EMILY_CDK_PROJECT_NAME) run build | ||
|
||
# Overwrite the default architecture with --arm64 configuration | ||
# on arm machines. | ||
ifneq (filter arm64 aarch64, $(shell uname -m),) | ||
_LAMBDA_FLAGS := --arm64 | ||
endif | ||
emily-lambda: emily-client | ||
cd emily/lambda \ | ||
&& cargo lambda build \ | ||
--release \ | ||
--package emily-lambda \ | ||
--output-format zip \ | ||
$(_LAMBDA_FLAGS) | ||
|
||
emily-client: | ||
pnpm --filter $(EMILY_API_PROJECT_NAME) run build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"name": "emily", | ||
"name": "emily-cdk", | ||
"version": "0.1.0", | ||
"bin": { | ||
"emily": "bin/emily.js" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just update this Github workflow to be something like "Run tests", since this will run both rust and JS tests? I'd be fine with that, and if there are Rust / Contract / etc workflows we want separately we can do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll change this to just be
run tests
and keep the contracts one because it looks like it does more than just this does. Ideally these wouldn't need to be separate because GitHub workflowss aren't really for testing, they're for preventing regression, and so long as the workflow is blocked when we mess something and we cursorily know why then we're good.