Fixed(Search-Filter): Connect Search Filter and endpoint request #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Rassl, Please review this PR. |
Rassl
reviewed
Sep 24, 2024
|
Hi @Rassl, Please review this PR. |
…/sphinx-nav-fiber into Connect-Search-Filter
|
Hi @Rassl, @tomsmith8, Please merge this PR. |
Rassl
requested changes
Oct 17, 2024
MirzaHanan
commented
Oct 18, 2024
| @@ -301,7 +301,10 @@ export const useDataStore = create<DataStore>()( | |||
| fetchData() | |||
| }, | |||
| resetDataNew: () => null, | |||
| setFilters: (filters: FilterParams) => set((state) => ({ filters: { ...state.filters, ...filters, page: 0 } })), | |||
| setFilters: (filters: Partial<FilterParams>) => { | |||
There was a problem hiding this comment.
Hi @Rassl, I believe you might have missed this part of the code. Could you please review it again? Everything is working well on my side now. Please see the demo:
There was a problem hiding this comment.
@Rassl, could you please scroll down a bit and take a look at the code above?
Rassl
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When a user confirms the filter, these should be used in the /graph/search request
node_typelimittop_node_countdepthcloses: #2180
Issue ticket number and link: