-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed(Search-Filter): Connect Search Filter and endpoint request #2211
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
35c4429
fix(search-filter): connect Search filter and endpoint request
MirzaHanan 9ac5349
Merge remote-tracking branch 'origin' into Connect-Search-Filter
MirzaHanan ccf1a53
fix(search-filter): connect Search filter and endpoint request
MirzaHanan e8d3d40
Merge remote-tracking branch 'origin' into Connect-Search-Filter
MirzaHanan cbdd26b
Merge branch 'Connect-Search-Filter' of https://github.com/MirzaHanan…
MirzaHanan a1c633e
Merge remote-tracking branch 'origin' into Connect-Search-Filter
MirzaHanan aaec478
Merge branch 'master' into Connect-Search-Filter
MirzaHanan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Rassl, I believe you might have missed this part of the code. Could you please review it again? Everything is working well on my side now. Please see the demo:
https://www.loom.com/share/5dec38ba89024a1c93ed297422478ec3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rassl, could you please scroll down a bit and take a look at the code above?