-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch out grpc
for @grpc/grpc-js
+ ts types
#423
Conversation
what does |
When a contact is added, you send a keysend with your |
ok got it, i think it didnt got a key back from the other party then... |
grpc
for @grpc/grpc-js
+ generated ts typesgrpc
for @grpc/grpc-js
~+ generated ts types~
grpc
for @grpc/grpc-js
~+ generated ts types~grpc
for @grpc/grpc-js
+ ~generated ts types~
grpc
for @grpc/grpc-js
+ ~generated ts types~grpc
for @grpc/grpc-js
@Evanfeenstra can you fix package-lock.json on master? it contains merge conflict markers... |
ok @antonilol its fixed |
Does that need to be |
lets try |
that will not fix the errors tho, the stack tests are not build around proxy. I would recommend cloning |
yeah i wanted to do this but stack comes with all types of random errors, like the one i described here stakwork/sphinx-stack#45 (i managed to fix this by running
|
i got stack working by running just |
4399888
to
d6aeedd
Compare
i got some more tests working now locally with only the bare minimum to get grpcjs working, without some suggested type checks |
i got all tests passing locally!!! |
grpc
for @grpc/grpc-js
grpc
for @grpc/grpc-js
+ ts types
what was the issue that was stopping key exchange? |
there were 3 issues:
|
79d85b6
to
97ea3a3
Compare
@antonilol so this file https://github.com/stakwork/sphinx-relay/blob/97ea3a3a34e42d5102c9396760ba706a0206d176/protobuf_long.patch is needed in order to make the |
71c7dd8
to
691cd60
Compare
Hey @antonilol were you able to manually test this change I pulled in the changes and I was only able to send out messages, receive wasn't working do you know if this would fail if you're running nodejs 12 or is it required it be updated? |
i use node v16, and it works. with node v12.22.12 i cant npm install because this protobuf patch doesnt apply. if i just start it on node v12 i get an error that mcrypt was compiled for a newer version of nodejs |
rebased |
Ok was able to get this running on nodejs 16 and it seems to be working fine with manual testing, just need to remember to update things from node 12 to 16 now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like linter is failing but otherwise I am good with these changes
this is fixed in #445, eslint misses some files and previous changes added warnings, can you merge it before this one? |
merged |
791cae2
to
bce6caa
Compare
rebased, got the warning count right and lint check passed now |
all tests passed except one port in use error (stakwork/sphinx-stack#47) |
test are passing now 🥳 |
rebased and ready to merge. did you manage to upgrade the lite nodes to nodejs v16? |
Sorry seeing this now, I'm trying to upgrade the nodes on our end just had to add more storage since the clusters we're getting full after trying to reinstall the node_modules. I have a script to auto update it just might take a long time update, I'm getting stuck on this node_modules when installing |
On my devices it also takes more time than other things done during |
2ecd889
to
09e8dba
Compare
rebased this and #362 |
thanks for rebasing I'm still in the process updating the clusters just ran into some issues and it takes a while to update each one so I'm doing them at night Thanks for your patience |
notes: * grpcjs doesnt like ByteBuffer, it has been replaced with the nodejs native Buffer * grpcjs doesnt like calls without an argument, add {} instead see src/grpc/subscribe.ts:24 * grpcjs converts uint64 in a map key (map<uint64, ...>) to some hash, this is fixed with protobuf_long.patch which is automatically applied after running `npm install` this pr would fix the bug upstream protobufjs/protobuf.js#1669
fixes #295
fixes #425
i managed to get
@grpc/grpc-js
working with camel_case fields,but still some tests are failingalso added generated typescript types for the grpc calls
all files in src/grpc/types/ are generated with the
./grpc_gen_types.sh
bash script, which also runs in gh workflows after updating the proto files