Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org Filter by Skill #12

Merged
merged 17 commits into from
Jan 29, 2024
Merged

Org Filter by Skill #12

merged 17 commits into from
Jan 29, 2024

Conversation

Vayras
Copy link
Contributor

@Vayras Vayras commented Jan 24, 2024

Resubmission of stakwork/sphinx-tribes#1430
issue:stakwork/sphinx-tribes#1315
with this PR I have implemented the skills filter on org Homepage
implementation involves modification of api call getOrganizationBounties and changes in frontend
loom video:https://www.loom.com/share/685883cc25b74f8bae633b85a5d41a00
test have been updated
tested on chrome

@ecurrencyhodler
Copy link
Contributor

Video looks good. Sorry one more thing. We have reverted our backend api calls from api.people-test->people.test. So we no longer will require the "api" in front of the call.

Can you push another commit? I think that'll trigger our github actions workflows for testing. Also in the future, you can run the tests locally as well using: yarn run.

@ecurrencyhodler
Copy link
Contributor

Hmmm you have a jest test failing now.

@Vayras
Copy link
Contributor Author

Vayras commented Jan 24, 2024

Hmmm you have a jest test failing now.

@ecurrencyhodler , This is persistent due to the modification of the getOrganizationBounties , we'll need review from @elraphty on this one

@Vayras
Copy link
Contributor Author

Vayras commented Jan 26, 2024

@ecurrencyhodler @elraphty fixed issues in this PR, I think we are good to go now , awaiting your review

@Vayras
Copy link
Contributor Author

Vayras commented Jan 26, 2024

Screenshot 2024-01-26 at 8 47 28 PM @elraphty I have updated the test file but I cannot run the test on my local machine getting this error

@Vayras
Copy link
Contributor Author

Vayras commented Jan 26, 2024

I think I will need assistance with this one, I cannot figure out the cause of this test failure

@Ekep-Obasi
Copy link
Contributor

Ekep-Obasi commented Jan 26, 2024

@Vayras, you have pushed
src/config/ModeDispatcher.tsx
src/config/host.ts

You should reset the AppMode back to TRIBES and return host instead of people-test.sphinx.chat

@Vayras
Copy link
Contributor Author

Vayras commented Jan 26, 2024

@Vayras, you have pushed src/config/ModeDispatcher.tsx src/config/host.ts

You should reset the AppMode back to TRIBES and return host instead of people-test.sphinx.chat

@Ekep-Obasi Thank you for your help , I might have pushed these with the other files an oversight at my end

@ecurrencyhodler
Copy link
Contributor

Wow great catch @Ekep-Obasi Thanks for the assist.

Let's get a code review.

@elraphty
Copy link
Collaborator

@Vayras fix the alignment of skill and status dropdowns

@Vayras
Copy link
Contributor Author

Vayras commented Jan 28, 2024

@Vayras fix the alignment of skill and status dropdowns

Sure, will fix this

@Vayras
Copy link
Contributor Author

Vayras commented Jan 28, 2024

@elraphty done with the changes

@elraphty elraphty merged commit a50c6ca into stakwork:master Jan 29, 2024
4 checks passed
@ecurrencyhodler
Copy link
Contributor

Tested it works nicely. well done. paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants