Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemntation of skills filter on org homepage #1315 #1430

Closed
wants to merge 20 commits into from
Closed

Implemntation of skills filter on org homepage #1315 #1430

wants to merge 20 commits into from

Conversation

Vayras
Copy link
Contributor

@Vayras Vayras commented Jan 21, 2024

#1315
with this PR I have implemented the skills filter on org Homepage
implementation involves modification of api call getOrganizationBounties and changes in frontend
loom video:https://www.loom.com/share/685883cc25b74f8bae633b85a5d41a00
test have been updated
tested on chrome

@Vayras
Copy link
Contributor Author

Vayras commented Jan 21, 2024

@elraphty @ecurrencyhodler modification of the getOrganizationBounties to accomadate filters is making it's test in main.spec.ts to fail , but it's modification is the optimal and efficient way to filters , though we can handle that in the frontend as well , currently I have tried to fix the tests but that did not work. let me know your opinion on this, Thanks

@ecurrencyhodler
Copy link
Contributor

Video looks good. Let's wait to see what raph has to say.

@elraphty
Copy link
Contributor

@Vayras what modification are you proposing?

@Vayras
Copy link
Contributor Author

Vayras commented Jan 23, 2024

@Vayras what modification are you proposing?

slight modifications to query params , passing the language string which enables filtering by coding language making the getOrgBounties , work similar to getPeopleBounites

@ecurrencyhodler
Copy link
Contributor

Hi! can you resubmit this PR to this new frontend repo? https://github.com/stakwork/sphinx-tribes-frontend

@ecurrencyhodler
Copy link
Contributor

New api endpoint for our backend is: https://api.people-test.sphinx.chat/

@Vayras
Copy link
Contributor Author

Vayras commented Jan 24, 2024

Hi! can you resubmit this PR to this new frontend repo? https://github.com/stakwork/sphinx-tribes-frontend

@ecurrencyhodler ofcourse ,will resubmit all the PRs related to frontend again on that repo

@Vayras
Copy link
Contributor Author

Vayras commented Jan 24, 2024

Resubmission : stakwork/sphinx-tribes-frontend#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants