Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1320):auto populate org #1343

Closed
wants to merge 9 commits into from
Closed

fix(#1320):auto populate org #1343

wants to merge 9 commits into from

Conversation

Vayras
Copy link
Contributor

@Vayras Vayras commented Jan 12, 2024

With this PR :
-Post bounty Modal auto populates the organization name
https://www.loom.com/share/e7323ceede244efd9b952b1c02820782?sid=82b6fce7-ef00-4a62-8220-c01447f7e3c8

--Notes On Current Implementation
the default value on the select comes from the api call getOrganizationByUuid , drop down values come from The Schema.ts file they act as mock organization data , alternatively we can call getOrganizationsById or create and alteranative function getAllOrganizations that will populate this the dropdown , note the commented code in this PR on file FocusView.tsx references to dropDown option which is an empty array ,that can be used in the future to prefetch dropdown data from backend

this has been tested on chrome and firefox , implements #1320

@ecurrencyhodler
Copy link
Contributor

all checks passed. Let's do a code review and discuss long term options for an implementation that vayras raised.

@ecurrencyhodler
Copy link
Contributor

@elraphty this one has been sitting for a while. Can you take a look?

@ecurrencyhodler
Copy link
Contributor

Hey Vayras. Just to give some context. Raph is taking his time reviewing this PR and testing it because it has the potential to break a lot of areas in our site. He'll update you when he's done.

@Vayras
Copy link
Contributor Author

Vayras commented Jan 19, 2024

Hey Vayras. Just to give some context. Raph is taking his time reviewing this PR and testing it because it has the potential to break a lot of areas in our site. He'll update you when he's done.

@ecurrencyhodler Thanks for your update , I will wait till Raph does the testing on this.

@elraphty
Copy link
Contributor

@Vayras Tested, this breaks the add bounty dropdown, you used hardcoded organizations, organizations are dynamic, and each user's organizations defer, so it cannot be hardcoded.

@Vayras
Copy link
Contributor Author

Vayras commented Jan 23, 2024

@elraphty Thanks for letting me know , I will update it with real organization values and update the PR

@Vayras
Copy link
Contributor Author

Vayras commented Jan 23, 2024

https://www.loom.com/share/62ef6756679a41c2a690316c6c9e987c @elraphty @ecurrencyhodler So I made some changes and can now see the list of the organization from backend as shown in the loom video , I cannot see the Bounties Platform Org in the list. The api endpoint I got the data from is ${TribesURL}/organizations ( pardon me for the washed out video , issue with loom)

@ecurrencyhodler
Copy link
Contributor

Hi! can you resubmit this PR to this new frontend repo? https://github.com/stakwork/sphinx-tribes-frontend

@ecurrencyhodler
Copy link
Contributor

New api endpoint for our backend is: https://api.people-test.sphinx.chat/

@Vayras
Copy link
Contributor Author

Vayras commented Jan 24, 2024

Hi! can you resubmit this PR to this new frontend repo? https://github.com/stakwork/sphinx-tribes-frontend

Sure , will do that , Thanks for your update

@Vayras
Copy link
Contributor Author

Vayras commented Jan 24, 2024

@elraphty @ecurrencyhodler I have update the workflow to get the value from backend and no longer the workflow needs hardcoded values. here is the video https://www.loom.com/share/6ef1ba861cd641dfa3d814e4ee66d52b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants