-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add declare_tx fixture to compilation tests #250
chore: add declare_tx fixture to compilation tests #250
Conversation
56c45e8
to
e47382b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware, @dafnamatsry, and @yair-starkware)
crates/gateway/src/compilation_test.rs
line 22 at r1 (raw file):
assert_matches!( rpc_declare_tx(), RpcTransaction::Declare(declare_tx) => declare_tx
Suggestion:
RpcTransaction::Declare(RpcDeclareTransaction::V3(declare_tx)) => declare_tx
e47382b
to
d52a40c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @dafnamatsry and @yair-starkware)
crates/gateway/src/compilation_test.rs
line 22 at r1 (raw file):
assert_matches!( rpc_declare_tx(), RpcTransaction::Declare(declare_tx) => declare_tx
Done.
d52a40c
to
0db4ea7
Compare
0db4ea7
to
6b8de0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry and @yair-starkware)
Importing this PR from the mempool repo: starkware-libs/mempool#515
This change is