Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add declare_tx fixture to compilation tests #250

Merged

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 1, 2024

Importing this PR from the mempool repo: starkware-libs/mempool#515


This change is Reviewable

@ArniStarkware ArniStarkware marked this pull request as ready for review August 1, 2024 11:02
@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch 2 times, most recently from 56c45e8 to e47382b Compare August 4, 2024 10:44
Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware, @dafnamatsry, and @yair-starkware)


crates/gateway/src/compilation_test.rs line 22 at r1 (raw file):

    assert_matches!(
        rpc_declare_tx(),
        RpcTransaction::Declare(declare_tx) => declare_tx

Suggestion:

RpcTransaction::Declare(RpcDeclareTransaction::V3(declare_tx)) => declare_tx

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from e47382b to d52a40c Compare August 5, 2024 08:21
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @dafnamatsry and @yair-starkware)


crates/gateway/src/compilation_test.rs line 22 at r1 (raw file):

    assert_matches!(
        rpc_declare_tx(),
        RpcTransaction::Declare(declare_tx) => declare_tx

Done.

@ArniStarkware ArniStarkware force-pushed the arni/declare/compilation/add_fixture_in_compile_test branch from 0db4ea7 to 6b8de0d Compare August 5, 2024 13:59
Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry and @yair-starkware)

@ArniStarkware ArniStarkware merged commit 39d2330 into main Aug 5, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
@ArniStarkware ArniStarkware deleted the arni/declare/compilation/add_fixture_in_compile_test branch August 13, 2024 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants