Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: streamline the error types in starknet_sierra_compile crate #566

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 22, 2024

The following PR in the stack concerns running the compiler in a process with a binary. I wanted to move some of the uninteresting upkeep to another PR.


This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Aug 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.39%. Comparing base (8753678) to head (d90b44a).
Report is 5 commits behind head on main.

Files Patch % Lines
...starknet_sierra_compile/src/cairo_lang_compiler.rs 0.00% 4 Missing and 2 partials ⚠️
crates/gateway/src/compilation.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
- Coverage   76.40%   76.39%   -0.02%     
==========================================
  Files         349      349              
  Lines       36968    36979      +11     
  Branches    36968    36979      +11     
==========================================
+ Hits        28247    28250       +3     
- Misses       6394     6402       +8     
  Partials     2327     2327              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/starknet_sierra_compile/error_types branch from baa9d89 to d90b44a Compare August 26, 2024 13:06
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@ArniStarkware ArniStarkware merged commit 0d773ce into main Aug 27, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
@ArniStarkware ArniStarkware deleted the arni/starknet_sierra_compile/error_types branch September 22, 2024 11:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants