-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: streamline the error types in starknet_sierra_compile crate #566
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on Graphite |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
==========================================
- Coverage 76.40% 76.39% -0.02%
==========================================
Files 349 349
Lines 36968 36979 +11
Branches 36968 36979 +11
==========================================
+ Hits 28247 28250 +3
- Misses 6394 6402 +8
Partials 2327 2327 ☔ View full report in Codecov by Sentry. |
7d4d6c7
to
90324db
Compare
f53c3c5
to
baa9d89
Compare
baa9d89
to
d90b44a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
The following PR in the stack concerns running the compiler in a process with a binary. I wanted to move some of the uninteresting upkeep to another PR.
This change is