derive subcomponentinput

[ohad-starkware]

This change is 

[ohad-starkware]

• derive lookup_data #261
• derive subcomponentinput #260 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ilyalesokhin-starkware]

stwo_cairo_prover/crates/air_structs_derive/src/lib.rs line 99 at r1 (raw file):

            quote! {
                #field_name: [(); #array_length].map(|_| Vec::with_capacity(capacity))

Merge loops.

Suggestion:

let v = Vec::with_capacity(capacity);
v.set_len(capacity);
v

[ilyalesokhin-starkware]

stwo_cairo_prover/crates/air_structs_derive/src/lib.rs line 36 at r1 (raw file):

    let mut vec_array_fields = Vec::new();

    if let Data::Struct(data_struct) = &input.data {

in the compiler repo we are using
https://docs.rs/syn/latest/syn/

https://github.com/starkware-libs/cairo/blob/932767340c4b8a762140bf9eba305f437587ac1b/crates/cairo-lang-proc-macros/src/rewriter.rs#L10

Code quote:

if let Data::Struct(data_struct) = &input.data {

[ilyalesokhin-starkware]

Reviewed 35 of 38 files at r1, all commit messages.
Reviewable status: 35 of 38 files reviewed, 2 unresolved discussions (waiting on @ohad-starkware)

---

stwo_cairo_prover/crates/air_structs_derive/src/lib.rs line 36 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

in the compiler repo we are using
https://docs.rs/syn/latest/syn/

https://github.com/starkware-libs/cairo/blob/932767340c4b8a762140bf9eba305f437587ac1b/crates/cairo-lang-proc-macros/src/rewriter.rs#L10

my main worry is that you have silent parsing errors here.

[ohad-starkware]

Reviewable status: 35 of 38 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

stwo_cairo_prover/crates/air_structs_derive/src/lib.rs line 99 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Merge loops.

Done.

[ilyalesokhin-starkware]

Reviewable status: 33 of 38 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)

---

stwo_cairo_prover/crates/air_structs_derive/src/lib.rs line 99 at r1 (raw file):

Previously, ohad-starkware (Ohad) wrote…

Done.

I don't see it.

[ohad-starkware]

Reviewable status: 33 of 38 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware and @ohad-starkware)

---

stwo_cairo_prover/crates/air_structs_derive/src/lib.rs line 99 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

I don't see it.

oh the expanded function right

[ilyalesokhin-starkware]

Reviewed 2 of 38 files at r1, 2 of 3 files at r2, 1 of 1 files at r5.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @ohad-starkware)

[ohad-starkware]

@Alon-Ti ptal

Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @ohad-starkware)

[Alon-Ti]

Reviewed 35 of 38 files at r1, 2 of 3 files at r2, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)