-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
derive lookup_data #261
base: main
Are you sure you want to change the base?
derive lookup_data #261
Conversation
5b7c782
to
cee8b86
Compare
0b6834a
to
10da291
Compare
cee8b86
to
0adc6bd
Compare
10da291
to
b00f8e6
Compare
0adc6bd
to
3833267
Compare
b00f8e6
to
0df33f5
Compare
0df33f5
to
dccdc01
Compare
I don't want this to be a list, and I think you get the error location from the compiler anyway, can you confirm? Suggestion: panic!("Expected a struct"); |
Can you fix the input to be a struct? Suggestion: strct: &DataStruct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 26 files at r1.
Reviewable status: 8 of 26 files reviewed, 3 unresolved discussions (waiting on @ohad-starkware)
stwo_cairo_prover/crates/air_structs_derive/src/lib.rs
line 30 at r1 (raw file):
#[proc_macro_derive(LookupData)] pub fn derive_lookup_data(input: proc_macro::TokenStream) -> proc_macro::TokenStream {
are you sure this should be in stwo-cairo and not in stwo?
Code quote:
derive_lookup_data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 8 of 26 files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware and @ohad-starkware)
stwo_cairo_prover/crates/air_structs_derive/src/lib.rs
line 30 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
are you sure this should be in stwo-cairo and not in stwo?
for now yes because airs in stwo do not share the same structure (sub components, add inputs etc) and I do want that logic to be all in the same place.
perhaps in the future, I added a todo
stwo_cairo_prover/crates/air_structs_derive/src/lib.rs
line 58 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
I don't want this to be a list, and I think you get the error location from the compiler anyway, can you confirm?
yes that is the case
done.
stwo_cairo_prover/crates/air_structs_derive/src/lib.rs
line 62 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
Can you fix the input to be a struct?
Done.
dccdc01
to
b65cb18
Compare
This change is