-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create QuotientLogBoundsVisitor. #407
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
076759a
to
f143ad8
Compare
a3ffbf4
to
e9a9eb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, all commit messages.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @alonh5)
src/core/air/mod.rs
line 96 at r2 (raw file):
self.visit_components(&mut bounds_visitor); let mut bounds = bounds_visitor.finalize(); bounds.push(self.max_constraint_log_degree_bound());
Add a comment that this is for the composition
e9a9eb7
to
8893fc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
src/core/air/mod.rs
line 96 at r2 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
Add a comment that this is for the composition
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)
This change is