Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create QuotientLogBoundsVisitor. #407

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Feb 26, 2024

This change is Reviewable

@alonh5 alonh5 force-pushed the 02-25-Create_ConstraintPointEvaluator branch from 076759a to f143ad8 Compare February 26, 2024 09:06
@alonh5 alonh5 changed the base branch from 02-25-Create_ConstraintPointEvaluator to dev February 26, 2024 10:12
@alonh5 alonh5 force-pushed the 02-26-Create_QuotientLogBoundsVisitor branch from a3ffbf4 to e9a9eb7 Compare February 26, 2024 10:12
@alonh5 alonh5 marked this pull request as ready for review February 26, 2024 10:12
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 4 files at r1, all commit messages.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @alonh5)


src/core/air/mod.rs line 96 at r2 (raw file):

        self.visit_components(&mut bounds_visitor);
        let mut bounds = bounds_visitor.finalize();
        bounds.push(self.max_constraint_log_degree_bound());

Add a comment that this is for the composition

@alonh5 alonh5 force-pushed the 02-26-Create_QuotientLogBoundsVisitor branch from e9a9eb7 to 8893fc7 Compare February 26, 2024 14:06
Copy link
Contributor Author

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)


src/core/air/mod.rs line 96 at r2 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

Add a comment that this is for the composition

Done.

Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@alonh5 alonh5 merged commit 022f832 into dev Feb 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants