-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create MaskEvaluator. #375
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
48e82ad
to
d715f45
Compare
490f6ef
to
f0374f4
Compare
d715f45
to
7d74c9d
Compare
f0374f4
to
f59916f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)
7d74c9d
to
383dde4
Compare
f59916f
to
6e162c1
Compare
383dde4
to
6ccceb2
Compare
6e162c1
to
77bbcff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)
src/core/mod.rs
line 18 at r3 (raw file):
/// A vector in which each element relates (by index) to a column in the trace. pub type ColumnVec<T> = Vec<T>; /// A vector of [ColumnVec]'s in which each element relates (by index) to a component in the air.
The documentation (and possibly the name) does not fit the implementation.
This is not jus one per component. it's one per column per component.
6ccceb2
to
fbb822d
Compare
77bbcff
to
0a49eae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
src/core/mod.rs
line 18 at r3 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
The documentation (and possibly the name) does not fit the implementation.
This is not jus one per component. it's one per column per component.
I changed the documentation to better explain what I meant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)
fbb822d
to
ae9b3c5
Compare
0a49eae
to
b8fa192
Compare
ae9b3c5
to
4eedc9b
Compare
b8fa192
to
3dc9048
Compare
The base branch was changed.
3dc9048
to
ad2a432
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)
This change is