Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create MaskEvaluator. #375

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Create MaskEvaluator. #375

merged 1 commit into from
Feb 26, 2024

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Feb 21, 2024

This change is Reviewable

@alonh5 alonh5 force-pushed the 02-21-Move_max_constraint_log_degree_bound_to_AirExt_trait branch from 48e82ad to d715f45 Compare February 21, 2024 12:49
@alonh5 alonh5 force-pushed the 02-21-Create_MaskEvaluator branch from 490f6ef to f0374f4 Compare February 21, 2024 12:49
@alonh5 alonh5 force-pushed the 02-21-Move_max_constraint_log_degree_bound_to_AirExt_trait branch from d715f45 to 7d74c9d Compare February 21, 2024 12:54
@alonh5 alonh5 force-pushed the 02-21-Create_MaskEvaluator branch from f0374f4 to f59916f Compare February 21, 2024 12:54
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@alonh5 alonh5 force-pushed the 02-21-Move_max_constraint_log_degree_bound_to_AirExt_trait branch from 7d74c9d to 383dde4 Compare February 21, 2024 15:46
@alonh5 alonh5 force-pushed the 02-21-Create_MaskEvaluator branch from f59916f to 6e162c1 Compare February 21, 2024 15:54
@alonh5 alonh5 force-pushed the 02-21-Move_max_constraint_log_degree_bound_to_AirExt_trait branch from 383dde4 to 6ccceb2 Compare February 22, 2024 10:04
@alonh5 alonh5 force-pushed the 02-21-Create_MaskEvaluator branch from 6e162c1 to 77bbcff Compare February 22, 2024 10:04
This was referenced Feb 22, 2024
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)


src/core/mod.rs line 18 at r3 (raw file):

/// A vector in which each element relates (by index) to a column in the trace.
pub type ColumnVec<T> = Vec<T>;
/// A vector of [ColumnVec]'s in which each element relates (by index) to a component in the air.

The documentation (and possibly the name) does not fit the implementation.
This is not jus one per component. it's one per column per component.

@alonh5 alonh5 force-pushed the 02-21-Move_max_constraint_log_degree_bound_to_AirExt_trait branch from 6ccceb2 to fbb822d Compare February 22, 2024 14:23
@alonh5 alonh5 force-pushed the 02-21-Create_MaskEvaluator branch from 77bbcff to 0a49eae Compare February 22, 2024 14:25
Copy link
Contributor Author

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)


src/core/mod.rs line 18 at r3 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

The documentation (and possibly the name) does not fit the implementation.
This is not jus one per component. it's one per column per component.

I changed the documentation to better explain what I meant.

Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@alonh5 alonh5 force-pushed the 02-21-Move_max_constraint_log_degree_bound_to_AirExt_trait branch from fbb822d to ae9b3c5 Compare February 25, 2024 08:24
@alonh5 alonh5 force-pushed the 02-21-Create_MaskEvaluator branch from 0a49eae to b8fa192 Compare February 25, 2024 08:24
@alonh5 alonh5 force-pushed the 02-21-Move_max_constraint_log_degree_bound_to_AirExt_trait branch from ae9b3c5 to 4eedc9b Compare February 26, 2024 08:31
@alonh5 alonh5 force-pushed the 02-21-Create_MaskEvaluator branch from b8fa192 to 3dc9048 Compare February 26, 2024 08:31
@alonh5 alonh5 changed the base branch from 02-21-Move_max_constraint_log_degree_bound_to_AirExt_trait to dev February 26, 2024 08:49
@alonh5 alonh5 dismissed spapinistarkware’s stale review February 26, 2024 08:49

The base branch was changed.

@alonh5 alonh5 force-pushed the 02-21-Create_MaskEvaluator branch from 3dc9048 to ad2a432 Compare February 26, 2024 08:49
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@alonh5 alonh5 merged commit 821d47c into dev Feb 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants