Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create FibonnaciAir. #369

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Create FibonnaciAir. #369

merged 1 commit into from
Feb 21, 2024

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Feb 20, 2024

This change is Reviewable

@alonh5 alonh5 mentioned this pull request Feb 20, 2024
@alonh5 alonh5 force-pushed the 02-20-Create_FibonnaciAir branch from d470120 to 7b934d7 Compare February 20, 2024 12:23
@alonh5 alonh5 force-pushed the 02-18-Contain_queries_in_FRI branch from 2a3e8c0 to d75a7d2 Compare February 20, 2024 12:50
@alonh5 alonh5 force-pushed the 02-20-Create_FibonnaciAir branch from 7b934d7 to aa83dde Compare February 20, 2024 12:50
@alonh5 alonh5 force-pushed the 02-18-Contain_queries_in_FRI branch from d75a7d2 to a361ae2 Compare February 20, 2024 13:51
@alonh5 alonh5 force-pushed the 02-20-Create_FibonnaciAir branch from aa83dde to 63ff0f7 Compare February 20, 2024 13:51
@alonh5 alonh5 force-pushed the 02-18-Contain_queries_in_FRI branch from a361ae2 to 0b08352 Compare February 20, 2024 14:20
@alonh5 alonh5 force-pushed the 02-20-Create_FibonnaciAir branch from 63ff0f7 to dc04cd9 Compare February 20, 2024 14:20
@alonh5 alonh5 force-pushed the 02-18-Contain_queries_in_FRI branch from 0b08352 to 3d7e129 Compare February 20, 2024 14:28
@alonh5 alonh5 force-pushed the 02-20-Create_FibonnaciAir branch 2 times, most recently from e4a5d52 to ea4744f Compare February 20, 2024 15:01
@alonh5 alonh5 force-pushed the 02-18-Contain_queries_in_FRI branch from 3d7e129 to 049669a Compare February 20, 2024 15:18
@alonh5 alonh5 force-pushed the 02-20-Create_FibonnaciAir branch from ea4744f to b24d7f2 Compare February 20, 2024 15:18
@alonh5 alonh5 force-pushed the 02-18-Contain_queries_in_FRI branch from 049669a to af57fa7 Compare February 20, 2024 15:20
@alonh5 alonh5 force-pushed the 02-20-Create_FibonnaciAir branch from b24d7f2 to 0b07f1a Compare February 20, 2024 15:20
@alonh5 alonh5 force-pushed the 02-18-Contain_queries_in_FRI branch from af57fa7 to 841f576 Compare February 20, 2024 15:31
@alonh5 alonh5 force-pushed the 02-20-Create_FibonnaciAir branch from 0b07f1a to 6edde67 Compare February 20, 2024 15:31
@alonh5 alonh5 force-pushed the 02-18-Contain_queries_in_FRI branch from 841f576 to 724f03a Compare February 20, 2024 15:39
@alonh5 alonh5 force-pushed the 02-20-Create_FibonnaciAir branch from 6edde67 to 8a851d2 Compare February 20, 2024 15:39
@alonh5 alonh5 changed the base branch from 02-18-Contain_queries_in_FRI to dev February 20, 2024 15:44
@alonh5 alonh5 force-pushed the 02-20-Create_FibonnaciAir branch from 8a851d2 to 0acd943 Compare February 20, 2024 15:44
This was referenced Feb 21, 2024
Copy link
Contributor Author

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7 and @spapinistarkware)


src/fibonacci/mod.rs line 127 at r2 (raw file):

        let component_trace = ComponentTrace::new(vec![&trace_commitment_scheme.polynomials[0]]);
        let component_traces = vec![component_trace];
        let evaluator = ConstraintEvaluator {

Extracted this into a function in PR 372.

Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

@alonh5 alonh5 force-pushed the 02-20-Create_FibonnaciAir branch from 318d38e to c2537b1 Compare February 21, 2024 12:54
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

@alonh5 alonh5 merged commit 0434d45 into dev Feb 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants